--max-jobs 0 should still build drvs with preferLocalBuild according to docs #855
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
ux
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#855
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
The documentation for max-jobs states:
but contrary to the docs, derivations with
preferLocalBuildset do not get built with--max-jobs 0Steps To Reproduce
nix build --option substitute false --option builders '' --max-jobs 0 --impure --expr '(import ./. {}).writeText "preferLocalBuildWithMaxJobs0" ""'Expected behavior
The above command succeeds.
nix --versionoutputnix (Lix, like Nix) 2.92.0Additional context
I'm not sure if the documented behavior was ever actually the case, and the language is a but unclear, so I might be reading it wrong, but it would be very useful to have a setting to allow only building derivations with
preferLocalBuildset. In some cases it may be desirable to disallow even those, so maybe ideally it should be a separate setting?It's a pretty weird feature I must say, fortunately, it doesn't create a situation where
preferLocalBuildsjust consumes arbitrary amount of tokens EXCEPT if you passmax-jobs = 0and your graph is ENTIRELY composed ofpreferLocalBuilds = true…This issue was mentioned on Gerrit on the following CLs:
preferLocalBuild = trueto bypassmax-jobs = 0")The main use case for this is, I think, to be able to build configuration files but to fail early if there is a cache miss for an actual package. In that case not having a setting to control slots is probably fine, as long as you actually trust derivations marked with preferLocalBuild are cheap.
I think a more general solution, would be replace the concept of slots with more fine grained resources. Then you could set the defaults for preferLocalBuild vs not preferLocalBuild derivations separately. There are of course many design considerations for how to make such a system robust.