Lix fails to evaluate a specifically nested attribute set #845
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
ux
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lix-project/lix#845
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Steps To Reproduce
attribute 'bar' already defined
.Expected behavior
There should be no errors, like latest Nix.
nix --version
outputI can reproduce with Lix 2.91.1. Moreover, the order of the attributes is important. If you swap the declarations, it doesn't fail
Would be nice to have someone bisect this. Given that it was in a pretty early release, I suspect it might stem from the parser rewrite itself
this was present in 2.18 already, it's not a lix regression
So Nix used to forbid this and then it got allowed in a later release after forking?
that seems to be the case. further tests show it failing all the way back to 2.3, so the bug is quite old
Just hit this switching from cppnix to lix, I think their bug is https://github.com/NixOS/nix/issues/11268, in which case the fix was in https://github.com/NixOS/nix/pull/11294 (landing in 2.26.)
@raito I see you just self assigned, but I can also take this over within a couple of months. This issue is literally over half a decade old so a couple of months shouldn't matter too much, and more importantly, I'm currently cleaning up the test suite as part of the functional2 migration so would prefer to have functional/lang tests frozen until then