Deprecate --system on the daemon or at least warn it's the wrong thing when it will blow up #694

New issue

Open

opened 2025-02-22 20:48:13 +00:00 by jade · 4 comments

jade commented

2025-02-22 20:48:13 +00:00

Owner

We occasionally have ux issues like this one and we could just stop this problem forever. --system should either not be accepted by the daemon from clients or it should generate a warning that they almost certainly mean --eval-system instead. The latter is easy, you can find how by looking at the trusted user implementation in the daemon which filters settings from the client; it would be in line with our "ignored setting because you're not trusted user" warning precedent.

jade added the

labels

2025-02-22 20:48:13 +00:00

dwt commented

2025-02-24 16:18:40 +00:00

@jade regarding #692 - the suggestion to use --eval-system does not seem to always work. I found two packages where I cannot get my linux builder to build using --eval-system, while it seems to at least most of the time work with --system. Recommending --eval-system seems to at least require additional configuration or some other small bit to make it work as a replacement for --system.

Actually, to be more precise, I haven't found a package yet that is not ported to my system yet, that I can compile using --eval-system.

@jade regarding #692 - the suggestion to use --eval-system does not seem to always work. I found two packages where I cannot get my linux builder to build using `--eval-system`, while it seems to at least most of the time work with `--system`. Recommending `--eval-system` seems to at least require additional configuration or some other small bit to make it work as a replacement for `--system`. Actually, to be more precise, I haven't found a package yet that is not ported to my system yet, that I can compile using `--eval-system`.

jade commented

2025-02-24 17:13:37 +00:00

Author

Owner

(note: that is a flakes bug where eval -system is not considered. the daemon probably still should ignore --system which would rectify the ux issue mentioned by actually dispatching to a remote builder in that case, assuming flakes even look at --system to begin with)

👍 1

lix-bot commented

2025-02-25 02:09:30 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/2657 ("fix: flakes now obey --eval-system")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/2657](https://gerrit.lix.systems/c/lix/+/2657) ("fix: flakes now obey --eval-system")

dwt commented

2025-02-25 07:05:44 +00:00

Got it, the bug is that this use case is supposed to work with --eval-system but it doesn't, and using --system only works accidentally some of the time.

Got it, the bug is that this use case is supposed to work with `--eval-system` but it doesn't, and using `--system` only works accidentally some of the time.