lix-project/lix

Fork 54

Lix overlay nix-prefetch-git upstream 2.18 does not exist anymore #632

New issue

Closed

opened 2025-01-20 09:44:53 +00:00 by greaka · 6 comments

greaka commented

2025-01-20 09:44:53 +00:00

Describe the bug

Similar to lix-project/lix#591

Being on nixpkgs-unstable channel, without flakes, I try to build a rust package. useFetchCargoVendor depends on nix-prefetch-git¹.

Lix fakes version 2.18 and tries to defer to upstream 2.18 for the featurues that Lix doesn't support:

  overridelist_2_18 = [
    "attic-client"
    "devenv"
    "nix-du"
    "nix-init"
    "nix-prefetch-git"
    "nixos-option"
    "nurl"
    "prefetch-yarn-deps" # force these onto upstream so we are not regularly rebuilding electron
  ];
  override_2_18 = prev.lib.genAttrs overridelist_2_18 (
    name: prev.${name}.override {
      nix = final.nixVersions.nix_2_18_upstream;
    });

2.18 however, has been removed upstream².

`nix --version` output

Lix 2.92.0

Additional context

Could you maybe link to the commit that should've fixed this in 2.91.1-2 for yarn deps?

## Describe the bug Similar to lix-project/lix#591 Being on `nixpkgs-unstable` channel, without flakes, I try to build a rust package. `useFetchCargoVendor` depends on `nix-prefetch-git`[^1]. Lix fakes version 2.18 and tries to defer to upstream 2.18 for the featurues that Lix doesn't support: ```nix overridelist_2_18 = [ "attic-client" "devenv" "nix-du" "nix-init" "nix-prefetch-git" "nixos-option" "nurl" "prefetch-yarn-deps" # force these onto upstream so we are not regularly rebuilding electron ]; override_2_18 = prev.lib.genAttrs overridelist_2_18 ( name: prev.${name}.override { nix = final.nixVersions.nix_2_18_upstream; }); ``` 2.18 however, has been removed upstream[^2]. ## `nix --version` output Lix 2.92.0 ## Additional context Could you maybe link to the commit that should've fixed this in 2.91.1-2 for yarn deps? [^1]: https://github.com/nixos/nixpkgs/blob/253a78627102ae2a284e7ca6911cf86f080d4ea7/pkgs/build-support/rust/fetch-cargo-vendor.nix#L58 [^2]: https://github.com/nixos/nixpkgs/blob/253a78627102ae2a284e7ca6911cf86f080d4ea7/pkgs/tools/package-management/nix/default.nix#L160

greaka added the

bug

label

2025-01-20 09:44:53 +00:00

greaka started working

2025-01-20 09:46:08 +00:00

greaka canceled time tracking

2025-01-20 09:46:12 +00:00

jade commented

2025-01-20 20:19:35 +00:00

Owner

I think this was fixed in a module revision? the code is definitely gone now as of 30e488a7d5

I'm not sure why this is broken for you; which version of the module are you using?

I think this was fixed in a module revision? the code is definitely gone now as of https://git.lix.systems/lix-project/nixos-module/commit/30e488a7d5748a5029dbda2a9e64ac709a4bae93 I'm not sure why this is broken for you; which version of the module are you using?

mmlb commented

2025-01-22 19:35:21 +00:00

I just ran into this when I tried to both update nixpkgs-unstable pin and update the lix module to 2.92.0. On a hunch I updated to latest nixpkgs-unstable just now 9e4d5190a9482a1fb9d18adf0bdb83c6e506eaab and then bumped lix module and had a successful build.

I just ran into this when I tried to both update nixpkgs-unstable pin and update the lix module to 2.92.0. On a hunch I updated to latest nixpkgs-unstable just now `9e4d5190a9482a1fb9d18adf0bdb83c6e506eaab` and then bumped lix module and had a successful build.

jade commented

2025-01-23 22:05:39 +00:00

Owner

I am guessing this is caused by running an outdated version of lix-module since this code should not exist at all anymore. Closing, but if it's not fixed by updating lix-module please follow up.

jade closed this issue

2025-01-23 22:05:39 +00:00

greaka commented

2025-01-24 07:21:42 +00:00

Author

Thanks mmlb, I didn't figure out that I had to bump the module manually, and I also forgot that I had to import it in each project separately.

Could this issue be turned into a documentation action please? I went through installing Lix, upgrading Lix and the beta guide before finding the link to switching to Lix again, where I saw that non-flake nixos configs hardcode a version number that I need to bump.

Thanks mmlb, I didn't figure out that I had to bump the module manually, and I also forgot that I had to import it in each project separately. Could this issue be turned into a documentation action please? I went through installing Lix, upgrading Lix and the beta guide before finding the link to [switching to Lix](https://lix.systems/add-to-config) again, where I saw that non-flake nixos configs hardcode a version number that I need to bump.

jade referenced this issue from lix-project/lix-website

2025-01-24 18:16:08 +00:00

Confusing non-flake documentation leads to people forgetting to update the module when they update Lix #43

jade commented

2025-01-24 18:16:22 +00:00

Owner

here's a bug filing: lix-project/lix-website#43

since 2.91 at the very least the module will complain at you if it's too old for the version of Lix it has, but it might have been too late to complain for this to have been visible for you.

oh, ugh. there's not really a good way of doing the non-flakes one, since you have to pin hashes if you want your stuff to work properly. the documentation is there as a starting point for you to adapt to whatever you use for this, npins, niv, etc, but if you use it as-written it is a pain to update. I can file a bug, but I don't really know what needs changing in the documentation to realistically actually fix this. here's a bug filing: https://git.lix.systems/lix-project/lix-website/issues/43 since 2.91 at the very least the module will complain at you if it's too old for the version of Lix it has, but it might have been too late to complain for this to have been visible for you.

❤️ 1

greaka commented

2025-01-24 18:20:21 +00:00

Author

Probably, I upgraded from 2.90. Thanks!