Delete vfork #6

New issue

Closed

opened 2024-03-07 05:10:43 +00:00 by jade · 2 comments

jade commented

2024-03-07 05:10:43 +00:00

Owner

wait what
wait what
nix forks before calling connect or bind???
and then wait()s on the child pid? wtf?
why???

Edit: we found later that the dubious code, 43d4d75e22, was because of sockaddr_un path length limits. offensive but at least halfway understandable. but surely someone could have left a comment or ... clarified the exact case when this could be required

> wait what > wait what > nix forks before calling connect or bind??? > and then wait()s on the child pid? wtf? > why??? Edit: we found later that the dubious code, https://github.com/nixos/nix/commit/43d4d75e22ea1f7ee2936fe725c1f7ea7a5005e6, was because of sockaddr_un path length limits. offensive but at least halfway understandable. but surely someone could have left a comment or ... clarified the exact case when this could be required