lix-project/lix
20
58
Fork 31
Code Issues 355 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Unable to build lix-2.92.0-dev-pre20241115-c859d03 on Intel based Mac #588

New issue
Closed
opened 2024-11-30 05:28:38 +00:00 by dstcruz · 8 comments
dstcruz commented 2024-11-30 05:28:38 +00:00
Copy link

Describe the bug

Building lix-2.92.0-dev-pre20241115-c859d03 fails with:

error: builder for '/nix/store/h3jmfd92bp7ql33a9qf8np7gzjqhrl4s-lix-2.92.0-dev-pre20241115-c859d03.drv' failed with exit code 1;
       last 25 log lines:
       >                 this->uploadData.reset(fmemopen(const_cast<char *>(uploadData->data()), uploadData->size(), "r"));
       >                                        ^~~~~~~~
       >                                        freopen
       > /nix/store/9l0nxr441n8qr0dk5n48m38dz4dswmg5-apple-sdk-10.12.2/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:248:7: note: 'freopen' declared here
       > FILE    *freopen(const char * __restrict, const char * __restrict,
       >          ^
       > ../src/libstore/filetransfer.cc:151:89: error: cannot initialize a parameter of type 'const char *' with an rvalue of type 'size_type' (aka 'unsigned long')
       >                 this->uploadData.reset(fmemopen(const_cast<char *>(uploadData->data()), uploadData->size(), "r"));
       >                                                                                         ^~~~~~~~~~~~~~~~~~
       > /nix/store/9l0nxr441n8qr0dk5n48m38dz4dswmg5-apple-sdk-10.12.2/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:248:63: note: passing argument to parameter here
       > FILE    *freopen(const char * __restrict, const char * __restrict,
       >                                                                  ^
       > 2 errors generated.
       > [105/515] Compiling C++ object src/libstore/liblixstore.dylib.p/export-import.cc.o
       > [106/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-binary-cache-store.cc.o
       > [107/515] Compiling C++ object src/libstore/liblixstore.dylib.p/http-binary-cache-store.cc.o
       > [108/515] Compiling C++ object src/libstore/liblixstore.dylib.p/lock.cc.o
       > [109/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-fs-store.cc.o
       > [110/515] Compiling C++ object src/libstore/liblixstore.dylib.p/legacy-ssh-store.cc.o
       > [111/515] Compiling C++ object src/libstore/liblixstore.dylib.p/daemon.cc.o
       > [112/515] Compiling C++ object src/libstore/liblixstore.dylib.p/gc.cc.o
       > [113/515] Compiling C++ object src/libstore/liblixstore.dylib.p/derivations.cc.o
       > [114/515] Compiling C++ object src/libstore/liblixstore.dylib.p/globals.cc.o
       > [115/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-store.cc.o
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/h3jmfd92bp7ql33a9qf8np7gzjqhrl4s-lix-2.92.0-dev-pre20241115-c859d03.drv'.

Steps To Reproduce

Run darwin-rebuild switch --flake .

Lix: https://git.lix.systems/api/v1/repos/lix-project/lix/archive/c859d03013712b349d82ee6223948d6d03e63a8d.tar.gz?rev=c859d03013712b349d82ee6223948d6d03e63a8d

Lix-module: https://git.lix.systems/api/v1/repos/lix-project/nixos-module/archive/15b999f9c958c475f71fb8c543b9fc2f36ae8730.tar.gz?rev=15b999f9c958c475f71fb8c543b9fc2f36ae8730

Expected behavior

A successful build

nix --version output

nix --version
nix (Lix, like Nix) 2.92.0-dev-pre20241109-b967f1d
## Describe the bug Building lix-2.92.0-dev-pre20241115-c859d03 fails with: ``` error: builder for '/nix/store/h3jmfd92bp7ql33a9qf8np7gzjqhrl4s-lix-2.92.0-dev-pre20241115-c859d03.drv' failed with exit code 1; last 25 log lines: > this->uploadData.reset(fmemopen(const_cast<char *>(uploadData->data()), uploadData->size(), "r")); > ^~~~~~~~ > freopen > /nix/store/9l0nxr441n8qr0dk5n48m38dz4dswmg5-apple-sdk-10.12.2/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:248:7: note: 'freopen' declared here > FILE *freopen(const char * __restrict, const char * __restrict, > ^ > ../src/libstore/filetransfer.cc:151:89: error: cannot initialize a parameter of type 'const char *' with an rvalue of type 'size_type' (aka 'unsigned long') > this->uploadData.reset(fmemopen(const_cast<char *>(uploadData->data()), uploadData->size(), "r")); > ^~~~~~~~~~~~~~~~~~ > /nix/store/9l0nxr441n8qr0dk5n48m38dz4dswmg5-apple-sdk-10.12.2/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:248:63: note: passing argument to parameter here > FILE *freopen(const char * __restrict, const char * __restrict, > ^ > 2 errors generated. > [105/515] Compiling C++ object src/libstore/liblixstore.dylib.p/export-import.cc.o > [106/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-binary-cache-store.cc.o > [107/515] Compiling C++ object src/libstore/liblixstore.dylib.p/http-binary-cache-store.cc.o > [108/515] Compiling C++ object src/libstore/liblixstore.dylib.p/lock.cc.o > [109/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-fs-store.cc.o > [110/515] Compiling C++ object src/libstore/liblixstore.dylib.p/legacy-ssh-store.cc.o > [111/515] Compiling C++ object src/libstore/liblixstore.dylib.p/daemon.cc.o > [112/515] Compiling C++ object src/libstore/liblixstore.dylib.p/gc.cc.o > [113/515] Compiling C++ object src/libstore/liblixstore.dylib.p/derivations.cc.o > [114/515] Compiling C++ object src/libstore/liblixstore.dylib.p/globals.cc.o > [115/515] Compiling C++ object src/libstore/liblixstore.dylib.p/local-store.cc.o > ninja: build stopped: subcommand failed. For full logs, run 'nix log /nix/store/h3jmfd92bp7ql33a9qf8np7gzjqhrl4s-lix-2.92.0-dev-pre20241115-c859d03.drv'. ``` ## Steps To Reproduce Run `darwin-rebuild switch --flake .` Lix: <https://git.lix.systems/api/v1/repos/lix-project/lix/archive/c859d03013712b349d82ee6223948d6d03e63a8d.tar.gz?rev=c859d03013712b349d82ee6223948d6d03e63a8d> Lix-module: <https://git.lix.systems/api/v1/repos/lix-project/nixos-module/archive/15b999f9c958c475f71fb8c543b9fc2f36ae8730.tar.gz?rev=15b999f9c958c475f71fb8c543b9fc2f36ae8730> ## Expected behavior A successful build ## `nix --version` output ```shell nix --version nix (Lix, like Nix) 2.92.0-dev-pre20241109-b967f1d ```
dstcruz added the
bug
 label 2024-11-30 05:28:38 +00:00
pennae commented 2024-11-30 11:34:14 +00:00
Owner
Copy link

apparently 10.12 is too old to have this function, it appeared only in 10.13. are you really running on an eight year old OS image or is it just choosing the wrong sdk version for some reason?

apparently 10.12 is too old to have this function, it appeared only in 10.13. are you really running on an eight year old OS image or is it just choosing the wrong sdk version for some reason?
dstcruz commented 2024-12-03 04:29:42 +00:00
Author
Copy link

I'm not sure how that SDK is being chosen. I'm definitely not running an old OS image—the OS is up to date with the latest version. I'm running nix-darwin, though I'm not sure if that's relevant. Any guidance on determining why this SDK is being used, and how to change that, would be much appreciated.

I'm not sure how that SDK is being chosen. I'm definitely not running an old OS image—the OS is up to date with the latest version. I'm running `nix-darwin`, though I'm not sure if that's relevant. Any guidance on determining why this SDK is being used, and how to change that, would be much appreciated.
szlend commented 2024-12-03 18:03:22 +00:00
Copy link

If you're on 24.11, you can try including apple-sdk_11 into lix's buildInputs. The x86_64 sdk is still behind to the aarch64 one in 24.11. That's going to be fixed in 25.05.

If you're on `24.11`, you can try including `apple-sdk_11` into lix's `buildInputs`. The x86_64 sdk is still behind to the aarch64 one in `24.11`. That's going to be fixed in `25.05`.
dstcruz commented 2024-12-05 21:14:39 +00:00
Author
Copy link

Can you show me how to add this buildInputs for lix to my nix-darwin flake config? After googling around, I'm still not sure how to do that. Here is my flake.nix.

Can you show me how to add this `buildInputs` for `lix` to my `nix-darwin` flake config? After googling around, I'm still not sure how to do that. Here is my [flake.nix](https://github.com/dstcruz/nixfiles/blob/main/flake.nix).
jade commented 2024-12-05 23:09:06 +00:00
Owner
Copy link

I would opine that this is still our bug, if everything involved is up to date. I am building a reproducer right now.

I would opine that this is still our bug, if everything involved is up to date. I am building a reproducer right now.
jade referenced this issue from a commit 2024-12-05 23:33:54 +00:00
build: fix on x86_64-darwin
jade commented 2024-12-05 23:44:29 +00:00
Owner
Copy link

alright yes, i can repro this. this is a lix bug. unfortunately i think fixing it is blocked on us upgrading to nixos-24.11, since the attribute names all got shuffled around and i do not want to write bad compat code.

we have a CL for it, it just needs some love.

alright yes, i can repro this. this is a lix bug. unfortunately i think fixing it is blocked on us upgrading to nixos-24.11, since the attribute names all got shuffled around and i do not want to write bad compat code. we have a CL for it, it just needs some love.
jade referenced this issue from a commit 2024-12-05 23:46:06 +00:00
build: fix on x86_64-darwin
jade referenced this issue from a commit 2024-12-06 01:20:19 +00:00
build: fix on x86_64-darwin
lix-bot commented 2024-12-06 01:21:11 +00:00
Member
Copy link

This issue was mentioned on Gerrit on the following CLs:

  • commit message in cl/2283 ("build: fix on x86_64-darwin")
<!-- GERRIT_LINKBOT: {"cls": [{"backlink": "https://gerrit.lix.systems/c/lix/+/2283", "number": 2283, "kind": "commit message"}], "cl_meta": {"2283": {"change_title": "build: fix on x86_64-darwin"}}} --> This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/2283](https://gerrit.lix.systems/c/lix/+/2283) ("build: fix on x86_64-darwin")
jade commented 2024-12-06 01:28:38 +00:00
Owner
Copy link

Verified fixed in that CL :)

Verified fixed in that CL :)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.91
sb/raito/phantom-referrers-gc
repl-overlay-example
reuse-compliance
release-2.90
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.91.1
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/cli

The command line interface of Lix

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

  
Area/flakes

   
Area/language

language design, features, extensions, etc

  
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol

The protocol, used for communicating between the client and the daemon

  
Area/releng

Release engineering

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
crash 💥

Lix crashes (possibly bad error handling)

  
Cross Compilation

   
devx

development experience issues

  
docs

requires or is about documentation changes

  
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#588
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?