Interacting with flakes fails in directories with non-ASCII UTF-8 characters #562

New issue

Closed

opened 2024-10-30 15:34:56 +00:00 by milibopp · 3 comments

milibopp commented

2024-10-30 15:34:56 +00:00

Describe the bug

When I run flake-related operations in a directory that has special characters anywhere in its path, Lix fails to properly encode those to Git, apparently escaping them improperly.

Steps To Reproduce

Make a directory with special characters in its name, for example "äöü"
Clone or initialize a git-based flake directory inside (e.g. git init && nix flake init)
Run any flake-interacting command on it (e.g. nix build)
See error (for example, see attached log)

Expected behavior

I can interact with the flake like usual.

`nix --version` output

nix (Lix, like Nix) 2.91.1

Additional context

None.

## Describe the bug When I run flake-related operations in a directory that has special characters anywhere in its path, Lix fails to properly encode those to Git, apparently escaping them improperly. ## Steps To Reproduce 1. Make a directory with special characters in its name, for example "äöü" 2. Clone or initialize a git-based flake directory inside (e.g. `git init && nix flake init`) 3. Run any flake-interacting command on it (e.g. `nix build`) 4. See error (for example, see attached log) ## Expected behavior I can interact with the flake like usual. ## `nix --version` output `nix (Lix, like Nix) 2.91.1` ## Additional context None.

lix.log

854 B

milibopp added the

bug

label 2024-10-30 15:34:56 +00:00

jade added the

Area/flakes

label 2024-11-10 02:36:44 +00:00

jade commented

2024-11-10 02:38:18 +00:00

Owner

oh. i know why this happens. it's because the stuff gets urlencoded because of the overall abuses of URLs in flakes and fetchTree. that's rather horrifying nonetheless and it should be fixed.

milibopp commented

2024-11-10 11:03:21 +00:00

Author

This seems easy enough to try to fix this myself actually. So perhaps I'll give it a go.

milibopp referenced this issue from a commit

2024-11-10 13:51:04 +00:00

libutil: fix non-ASCII chars in URL encoding

milibopp referenced this issue from a commit

2024-11-10 13:52:10 +00:00

libutil: fix non-ASCII chars in URL encoding

lix-bot commented

2024-11-10 14:33:42 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/2173 ("libutil: fix non-ASCII chars in URL encoding")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/2173](https://gerrit.lix.systems/c/lix/+/2173) ("libutil: fix non-ASCII chars in URL encoding")

milibopp changed title from ~~Interacting with flakes fails in directories with special characters~~ to Interacting with flakes fails in directories with non-ASCII UTF-8 characters

2024-11-11 13:33:04 +00:00