Fix Wsign-compare in darwin platform code #548

New issue

Closed

opened 2024-10-14 23:44:31 +00:00 by jade · 1 comment

jade commented

2024-10-14 23:44:31 +00:00

Owner

Found while compiling HEAD as of this writing with nixos unstable.

lix> ../src/libstore/platform/darwin.cc:23:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
lix>     while (pidBufSize > pids.size() * sizeof(int)) {
lix>            ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
lix> ../src/libstore/platform/darwin.cc:57:30: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
lix>             while (fdBufSize > fds.size() * sizeof(struct proc_fdinfo)) {
lix>                    ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lix> 2 warnings generated.

Found while compiling HEAD as of this writing with nixos unstable. ``` lix> ../src/libstore/platform/darwin.cc:23:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] lix> while (pidBufSize > pids.size() * sizeof(int)) { lix> ~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ lix> ../src/libstore/platform/darwin.cc:57:30: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare] lix> while (fdBufSize > fds.size() * sizeof(struct proc_fdinfo)) { lix> ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lix> 2 warnings generated. ```

jade added the

labels 2024-10-14 23:44:31 +00:00

lix-bot commented

2024-10-20 20:13:33 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/2091 ("libstore: fix sign comparison warnings in darwin platform")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/2091](https://gerrit.lix.systems/c/lix/+/2091) ("libstore: fix sign comparison warnings in darwin platform")