lix-project/lix
20
57
Fork 31
Code Issues 342 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Packaging lix for openSUSE: dependency pegtl not found #471

New issue
Closed
opened 2024-08-16 07:18:43 +00:00 by kastl-ars · 10 comments
kastl-ars commented 2024-08-16 07:18:43 +00:00
Copy link

Hi,

I am trying to package lix for openSUSE, but I fail to get it working due to pegtl. Running meson setup build --prefix="$PWD/outputs/out" I get this:

[   76s] Project name: lix
[   76s] Project version: 
[   76s] C++ compiler for the host machine: c++ (gcc 13.3.1 "c++ (SUSE Linux) 13.3.1 20240807 [revision 9d368828bd4d04ce507e02a581be850fca849fae]")
[   76s] C++ linker for the host machine: c++ ld.bfd 2.43.0.20240806-1
[   76s] Host machine cpu family: x86_64
[   76s] Host machine cpu: x86_64
[   76s] Program doxygen found: YES (/usr/bin/doxygen)
[   76s] Program bash found: YES (/usr/bin/bash)
[   76s] Found pkg-config: YES (/usr/bin/pkg-config) 2.2.0
[   76s] Run-time dependency rapidcheck found: YES
[   76s] Message: canonical Nix system name: x86_64-linux
[   76s] Found CMake: /usr/bin/cmake (3.30.2)
[   76s] Run-time dependency bdw-gc found: NO (tried pkgconfig and cmake)
[   76s] Run-time dependency Boost (found: container) found: YES 1.85.0 (/usr)
[   76s] Run-time dependency libcpuid found: YES 0.6.5
[   76s] Run-time dependency libseccomp found: YES 2.5.5
[   76s] Run-time dependency libarchive found: YES 3.7.4
[   76s] Run-time dependency libbrotlicommon found: YES 1.1.0
[   76s] Run-time dependency libbrotlidec found: YES 1.1.0
[   76s] Run-time dependency libbrotlienc found: YES 1.1.0
[   76s] Run-time dependency libcrypto found: YES 3.1.4
[   76s] Run-time dependency aws-cpp-sdk-core found: YES 1.11.378
[   76s] Run-time dependency aws-cpp-sdk-transfer found: YES 1.11.378
[   76s] Run-time dependency aws-cpp-sdk-s3 found: YES 1.11.378
[   76s] Run-time dependency sqlite3 found: YES 3.46.0
[   76s] Run-time dependency libsodium found: YES 1.0.20
[   76s] Run-time dependency libcurl found: YES 8.9.1
[   76s] Run-time dependency libeditline found: YES 1.17.1
[   76s] Run-time dependency lowdown found: YES 1.1.0
[   76s] Dependency rapidcheck found: YES unknown (cached)
[   76s] Run-time dependency GTest found: YES 1.14.0
[   76s] Run-time dependency gtest_main found: YES 1.14.0
[   76s] Run-time dependency GMock found: YES 1.14.0
[   76s] Run-time dependency gmock_main found: YES 1.14.0
[   76s] Run-time dependency toml11 found: YES 3.7.1
[   76s] Run-time dependency pegtl found: NO (tried cmake)
[   76s] 
[   76s] meson.build:314:8: ERROR: Dependency "pegtl" not found, tried cmake

There is a pegtl-devel package, that apparently installs the needed dependencies to /usr/include/tao/pegtl/. But for whatever reason it is not being found.

I saw that the pegtl is defined in the meson.build file. I tried changing the modules line to read tao:pegtl, as the path is not containing cpp on openSUSE, but to no avail.

Any idea how to get meson / cmake to find the package?

Kind Regards,
Johannes

Hi, I am trying to package lix for openSUSE, but I fail to get it working due to pegtl. Running `meson setup build --prefix="$PWD/outputs/out"` I get this: ``` [ 76s] Project name: lix [ 76s] Project version: [ 76s] C++ compiler for the host machine: c++ (gcc 13.3.1 "c++ (SUSE Linux) 13.3.1 20240807 [revision 9d368828bd4d04ce507e02a581be850fca849fae]") [ 76s] C++ linker for the host machine: c++ ld.bfd 2.43.0.20240806-1 [ 76s] Host machine cpu family: x86_64 [ 76s] Host machine cpu: x86_64 [ 76s] Program doxygen found: YES (/usr/bin/doxygen) [ 76s] Program bash found: YES (/usr/bin/bash) [ 76s] Found pkg-config: YES (/usr/bin/pkg-config) 2.2.0 [ 76s] Run-time dependency rapidcheck found: YES [ 76s] Message: canonical Nix system name: x86_64-linux [ 76s] Found CMake: /usr/bin/cmake (3.30.2) [ 76s] Run-time dependency bdw-gc found: NO (tried pkgconfig and cmake) [ 76s] Run-time dependency Boost (found: container) found: YES 1.85.0 (/usr) [ 76s] Run-time dependency libcpuid found: YES 0.6.5 [ 76s] Run-time dependency libseccomp found: YES 2.5.5 [ 76s] Run-time dependency libarchive found: YES 3.7.4 [ 76s] Run-time dependency libbrotlicommon found: YES 1.1.0 [ 76s] Run-time dependency libbrotlidec found: YES 1.1.0 [ 76s] Run-time dependency libbrotlienc found: YES 1.1.0 [ 76s] Run-time dependency libcrypto found: YES 3.1.4 [ 76s] Run-time dependency aws-cpp-sdk-core found: YES 1.11.378 [ 76s] Run-time dependency aws-cpp-sdk-transfer found: YES 1.11.378 [ 76s] Run-time dependency aws-cpp-sdk-s3 found: YES 1.11.378 [ 76s] Run-time dependency sqlite3 found: YES 3.46.0 [ 76s] Run-time dependency libsodium found: YES 1.0.20 [ 76s] Run-time dependency libcurl found: YES 8.9.1 [ 76s] Run-time dependency libeditline found: YES 1.17.1 [ 76s] Run-time dependency lowdown found: YES 1.1.0 [ 76s] Dependency rapidcheck found: YES unknown (cached) [ 76s] Run-time dependency GTest found: YES 1.14.0 [ 76s] Run-time dependency gtest_main found: YES 1.14.0 [ 76s] Run-time dependency GMock found: YES 1.14.0 [ 76s] Run-time dependency gmock_main found: YES 1.14.0 [ 76s] Run-time dependency toml11 found: YES 3.7.1 [ 76s] Run-time dependency pegtl found: NO (tried cmake) [ 76s] [ 76s] meson.build:314:8: ERROR: Dependency "pegtl" not found, tried cmake ``` There is a pegtl-devel package, that apparently installs the needed dependencies to `/usr/include/tao/pegtl/`. But for whatever reason it is not being found. I saw that the pegtl is defined in the `meson.build` file. I tried changing the `modules` line to read `tao:pegtl`, as the path is not containing `cpp` on openSUSE, but to no avail. Any idea how to get meson / cmake to find the package? Kind Regards, Johannes
jade commented 2024-08-16 14:18:56 +00:00
Owner
Copy link

Hello and thank you for your work!

Here's our pegtl package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/pe/pegtl/package.nix

It appears that it's completely devoid of content, so i think it's just using the bog standard cmake build, test, install flow. Does your pegtl package expose whichever cmake/pkg-config/etc shipped by upstream?

You can inspect the files installed by ours with nix build -f '<nixpkgs>' 'pegtl^*' then looking in the result* symlinks. It is possible, though it would be infuriating, that some of the shenanigans done by the nixpkgs stdenv and cc wrapper somehow were load bearing here but I don't think so: this should just be using pkg-config or cmake.

Hello and thank you for your work! Here's our pegtl package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/pe/pegtl/package.nix It appears that it's completely devoid of content, so i think it's just using the bog standard cmake build, test, install flow. Does your pegtl package expose whichever cmake/pkg-config/etc shipped by upstream? You can inspect the files installed by ours with `nix build -f '<nixpkgs>' 'pegtl^*'` then looking in the result* symlinks. It is possible, though it would be infuriating, that some of the shenanigans done by the nixpkgs stdenv and cc wrapper somehow were load bearing here but I don't think so: this should just be using pkg-config or cmake.
lilyinstarlight commented 2024-08-16 14:36:11 +00:00
Owner
Copy link

For what it's worth, it looks like openSUSE does include the necessary CMake files that we use to find pegtl at /usr/share/cmake/Modules/pegtl-config{,-version}.cmake and those definitely do use a target/module name of taocpp::pegtl

I'm not sure how meson looks up CMake modules though, so something might be wonky there

For what it's worth, it looks like openSUSE does include the necessary CMake files that we use to find pegtl at `/usr/share/cmake/Modules/pegtl-config{,-version}.cmake` and those definitely do use a target/module name of `taocpp::pegtl` I'm not sure how meson looks up CMake modules though, so something might be wonky there
lilyinstarlight commented 2024-08-16 14:45:34 +00:00
Owner
Copy link

Actually is line 66 correct in the rpmspec for pegtl at https://build.opensuse.org/projects/openSUSE:Factory/packages/pegtl/files/pegtl.spec?expand=1? I think it maybe should be going to %{_libdir}/cmake/pegtl instead of ${_datadir}/cmake/Modules

(edit: See https://cmake.org/cmake/help/book/mastering-cmake/chapter/Finding%20Packages.html for differences in Module mode vs Config mode for finding CMake packages -- this generates for Config mode but the current directory the rpmspec is placing the file into is only searched for Module mode)

Actually is line 66 correct in the rpmspec for pegtl at <https://build.opensuse.org/projects/openSUSE:Factory/packages/pegtl/files/pegtl.spec?expand=1>? I think it maybe should be going to `%{_libdir}/cmake/pegtl` instead of `${_datadir}/cmake/Modules` (edit: See <https://cmake.org/cmake/help/book/mastering-cmake/chapter/Finding%20Packages.html> for differences in Module mode vs Config mode for finding CMake packages -- this generates for Config mode but the current directory the rpmspec is placing the file into is only searched for Module mode)
jade commented 2024-08-16 14:58:16 +00:00
Owner
Copy link

If I recall correctly you can get the full details out of the build directory somewhere, and the meson configure log mentioned in the configure failure message gives some detail on the fake meson project in use.

If I recall correctly you can get the full details out of the build directory somewhere, and the meson configure log mentioned in the configure failure message gives some detail on the fake meson project in use.
johanneskastl commented 2024-08-16 17:59:09 +00:00
Copy link

For what it's worth, it looks like openSUSE does include the necessary CMake files that we use to find pegtl at /usr/share/cmake/Modules/pegtl-config{,-version}.cmake and those definitely do use a target/module name of taocpp::pegtl

I'm not sure how meson looks up CMake modules though, so something might be wonky there

Thanks for checking.

I switched to using meson instead of just, because yet another layer of abstraction seemed to not make things better.

Maybe I am just missing an option for meson, probably one of the many things that might be set in $mesonFlags? I have not found out how 'just' would set them, I just found that packages.nix contains lots of things that might (or might not) be in there.

> For what it's worth, it looks like openSUSE does include the necessary CMake files that we use to find pegtl at `/usr/share/cmake/Modules/pegtl-config{,-version}.cmake` and those definitely do use a target/module name of `taocpp::pegtl` > > I'm not sure how meson looks up CMake modules though, so something might be wonky there Thanks for checking. I switched to using meson instead of just, because yet another layer of abstraction seemed to not make things better. Maybe I am just missing an option for meson, probably one of the many things that might be set in `$mesonFlags`? I have not found out how 'just' would set them, I just found that packages.nix contains lots of things that might (or might not) be in there.
johanneskastl commented 2024-08-16 18:01:09 +00:00
Copy link

Actually is line 66 correct in the rpmspec for pegtl at https://build.opensuse.org/projects/openSUSE:Factory/packages/pegtl/files/pegtl.spec?expand=1? I think it maybe should be going to %{_libdir}/cmake/pegtl instead of ${_datadir}/cmake/Modules

(edit: See https://cmake.org/cmake/help/book/mastering-cmake/chapter/Finding%20Packages.html for differences in Module mode vs Config mode for finding CMake packages -- this generates for Config mode but the current directory the rpmspec is placing the file into is only searched for Module mode)

I can try repackaging, but as this package is already in Tumbleweed and seems to be used by other packages, I daresay it should be correct. Of course, it might be correct with an option that other packages are handing over to meson/cmake to have it find the packages.

But other packages were found by the lix meson/cmake build, so it may be a flaw in the package.

> Actually is line 66 correct in the rpmspec for pegtl at <https://build.opensuse.org/projects/openSUSE:Factory/packages/pegtl/files/pegtl.spec?expand=1>? I think it maybe should be going to `%{_libdir}/cmake/pegtl` instead of `${_datadir}/cmake/Modules` > > (edit: See <https://cmake.org/cmake/help/book/mastering-cmake/chapter/Finding%20Packages.html> for differences in Module mode vs Config mode for finding CMake packages -- this generates for Config mode but the current directory the rpmspec is placing the file into is only searched for Module mode) I can try repackaging, but as this package is already in Tumbleweed and seems to be used by other packages, I daresay it should be correct. Of course, it might be correct with an option that other packages are handing over to meson/cmake to have it find the packages. But other packages were found by the lix meson/cmake build, so it may be a flaw in the package.
johanneskastl commented 2024-08-16 18:58:48 +00:00
Copy link

OK, I tried with a modified version of the pegtl package. Actually two, one with the cmake modules in _libdir and one completely without them.

Both tries failed.

So I daresay the pegtl-devel package is not the problem, somehow meson/cmake fail to find it for $REASONS.

OK, I tried with a modified version of the pegtl package. Actually two, one with the cmake modules in `_libdir` and one completely without them. Both tries failed. So I daresay the pegtl-devel package is not the problem, somehow meson/cmake fail to find it for $REASONS.
lilyinstarlight commented 2024-08-16 21:34:30 +00:00
Owner
Copy link

With the following changes to your pegtl.spec file at https://build.opensuse.org/projects/home:ojkastl_buildservice:Branch_devel_tools/packages/pegtl/files/pegtl.spec?expand=1, it seems to work for me. Does this work for you?

diff --git a/pegtl.spec b/pegtl.spec
index 8f91236..f1c15c7 100644
--- a/pegtl.spec
+++ b/pegtl.spec
@@ -60,7 +60,7 @@ PEGTL (Parsing Expression Grammar Template Library).
 %build
 %cmake \
   -DPEGTL_INSTALL_DOC_DIR:PATH=%{_defaultdocdir}/pegtl \
-  -DPEGTL_INSTALL_CMAKE_DIR:PATH=%{_libdir}/cmake/Modules \
+  -DPEGTL_INSTALL_CMAKE_DIR:PATH=%{_libdir}/cmake/pegtl \
   -DPEGTL_BUILD_EXAMPLES:BOOL=OFF \
   -DPEGTL_BUILD_TESTS:BOOL=ON
 
@@ -69,13 +69,13 @@ PEGTL (Parsing Expression Grammar Template Library).
 %install
 %cmake_install
 rm %{buildroot}%{_defaultdocdir}/pegtl/LICENSE
-rm -rf %{buildroot}%{_libdir}/cmake/Modules
 
 %check
 %ctest
 
 %files devel
 %{_includedir}/*
+%{_libdir}/cmake/pegtl
 
 %files devel-doc
 %license LICENSE
With the following changes to your `pegtl.spec` file at <https://build.opensuse.org/projects/home:ojkastl_buildservice:Branch_devel_tools/packages/pegtl/files/pegtl.spec?expand=1>, it seems to work for me. Does this work for you? ```diff diff --git a/pegtl.spec b/pegtl.spec index 8f91236..f1c15c7 100644 --- a/pegtl.spec +++ b/pegtl.spec @@ -60,7 +60,7 @@ PEGTL (Parsing Expression Grammar Template Library). %build %cmake \ -DPEGTL_INSTALL_DOC_DIR:PATH=%{_defaultdocdir}/pegtl \ - -DPEGTL_INSTALL_CMAKE_DIR:PATH=%{_libdir}/cmake/Modules \ + -DPEGTL_INSTALL_CMAKE_DIR:PATH=%{_libdir}/cmake/pegtl \ -DPEGTL_BUILD_EXAMPLES:BOOL=OFF \ -DPEGTL_BUILD_TESTS:BOOL=ON @@ -69,13 +69,13 @@ PEGTL (Parsing Expression Grammar Template Library). %install %cmake_install rm %{buildroot}%{_defaultdocdir}/pegtl/LICENSE -rm -rf %{buildroot}%{_libdir}/cmake/Modules %check %ctest %files devel %{_includedir}/* +%{_libdir}/cmake/pegtl %files devel-doc %license LICENSE ```
johanneskastl commented 2024-08-17 07:45:22 +00:00
Copy link

Thanks for checking @lilyinstarlight,

I can confirm that the lix package finds the pegtl library with your changes.

I'll submit them upstream and see what the openSUSE folks say.

Thanks for checking @lilyinstarlight, I can confirm that the lix package finds the pegtl library with your changes. I'll submit them upstream and see what the openSUSE folks say.
👍 1 ❤️ 1
johanneskastl commented 2024-08-17 07:50:07 +00:00
Copy link

Hmm, I can't close this issue. Could someone close it, please?

Hmm, I can't close this issue. Could someone close it, please?
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.91
sb/raito/phantom-referrers-gc
repl-overlay-example
reuse-compliance
release-2.90
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.91.1
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/cli

The command line interface of Lix

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

  
Area/flakes

   
Area/language

language design, features, extensions, etc

  
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol

The protocol, used for communicating between the client and the daemon

  
Area/releng

Release engineering

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
crash 💥

Lix crashes (possibly bad error handling)

  
Cross Compilation

   
devx

development experience issues

  
docs

requires or is about documentation changes

  
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#471
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?