Packaging lix for openSUSE: is the coreutils binary really needed? #470

New issue

Closed

opened 2024-08-16 06:45:52 +00:00 by kastl-ars · 3 comments

kastl-ars commented

2024-08-16 06:45:52 +00:00

Hi,

I am trying to package lix for openSUSE. One issue I ran into was the dependency on the coreutils binary (not the package).

coreutils = find_program('coreutils', native : true)

https://git.lix.systems/lix-project/lix/src/branch/main/meson.build#L339

When searching for usage of the coreutils binary, I fail to spot any actual usage.
https://git.lix.systems/lix-project/lix/search?q=coreutils

Can it be that the requirement is for the coreutils tools to be installed, specifically the id and env binaries?

The reason why I ask is that it is a little harder to get the actual coreutils binary on openSUSE, while the coreutils package containing all the different binaries is installed pretty much by default...

Kind Regards,
Johannes

Hi, I am trying to package lix for openSUSE. One issue I ran into was the dependency on the coreutils binary (not the package). ``` coreutils = find_program('coreutils', native : true) ``` https://git.lix.systems/lix-project/lix/src/branch/main/meson.build#L339 When searching for usage of the coreutils binary, I fail to spot any actual usage. https://git.lix.systems/lix-project/lix/search?q=coreutils Can it be that the requirement is for the coreutils tools to be installed, specifically the `id` and `env` binaries? The reason why I ask is that it is a little harder to get the actual `coreutils` binary on openSUSE, while the coreutils package containing all the different binaries is installed pretty much by default... Kind Regards, Johannes

jade commented

2024-08-16 14:21:43 +00:00

Owner

I speculate this is possibly a badly written guard against BSD coreutils, maybe inherited from the since removed make build system. @qyriad may know more.

johanneskastl commented

2024-08-17 08:54:22 +00:00

I tried some crude hacks before building, which at least starts the compilation process:

sed -i "/^coreutils/a id = find_program('id', native: true)" meson.build
sed -i "/^coreutils/a id = find_program('env', native: true)" meson.build
sed -i '/coreutils/d' meson.build
sed -i '/coreutils/d' tests/functional/meson.build

This makes meson look for id and env instead of the coreutils binary.

tests/nixos/setuid/setuid.nix
Line 54 in 41a0b08
cp ${pkgs.coreutils}/bin/id /tmp/id
ff.
docker.nix
Line 292 in 41a0b08
ln -s ${pkgs.coreutils}/bin/env $out/usr/bin/env

And it removes the apparently unused variable from tests/functional/meson.build.

This way the compilation starts up (it fails later due to unrelated reasons, but at least it starts).

I tried some crude hacks before building, which at least starts the compilation process: ``` sed -i "/^coreutils/a id = find_program('id', native: true)" meson.build sed -i "/^coreutils/a id = find_program('env', native: true)" meson.build sed -i '/coreutils/d' meson.build sed -i '/coreutils/d' tests/functional/meson.build ``` This makes meson look for `id` and `env` instead of the `coreutils` binary. - https://git.lix.systems/lix-project/lix/src/commit/41a0b08e646b54b27ae49fb4c23e0c45c60369ca/tests/nixos/setuid/setuid.nix#L54 ff. - https://git.lix.systems/lix-project/lix/src/commit/41a0b08e646b54b27ae49fb4c23e0c45c60369ca/docker.nix#L292 And it removes the apparently unused variable from `tests/functional/meson.build`. This way the compilation starts up (it fails later due to unrelated reasons, but at least it starts).