Fix nix-shell arguments script-directory relativity #451

New issue

Open

opened 2024-07-17 22:19:54 +00:00 by jade · 2 comments

jade commented

2024-07-17 22:19:54 +00:00

Owner

Currently a nix-shell shebang is evaluated relative to the working directory of the calling process. This essentially does not work if you want to reference any other nix file.

CppNix has some fixes here: https://github.com/NixOS/nix/pull/11058

These could possibly be ported.

Currently a nix-shell shebang is evaluated relative to the working directory of the calling process. This essentially does not work if you want to reference any other nix file. CppNix has some fixes here: https://github.com/NixOS/nix/pull/11058 These could possibly be ported.

qyriad added the

E/easy

label

2024-08-02 16:52:11 +00:00

jade added the

E/help wanted

label

2024-08-18 21:49:34 +00:00

jade commented

2024-10-04 21:43:29 +00:00

Author

Owner

Issues with the PR to be addressed when porting:

nix-shell-shebang-arguments-relative-to-script should be a DeprecatedFeature (infrastructure which CppNix does not have) instead of a separate setting
Obviously the stuff that says Nix 2.24 needs fixing
Release notes need to be reformatted to use our richer front-matter syntax
That whole thing should just be squashed into one commit. There is way too much commit history in there.

Rest of it looks largely okay.

Issues with the PR to be addressed when porting: - nix-shell-shebang-arguments-relative-to-script should be a DeprecatedFeature (infrastructure which CppNix does not have) instead of a separate setting - Obviously the stuff that says Nix 2.24 needs fixing - Release notes need to be reformatted to use our richer front-matter syntax - That whole thing should just be squashed into one commit. There is way too much commit history in there. Rest of it looks largely okay.

lix-bot commented

2024-10-12 23:22:21 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/2062 ("feat!: change default nix-shell shebang behavior")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/2062](https://gerrit.lix.systems/c/lix/+/2062) ("feat!: change default nix-shell shebang behavior")