nix-collect-garbage --dry-run
flag has incorrect behaviour #432
Labels
No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lix-project/lix#432
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
The
--dry-run
flag innix-collect-garbage
doesn't print out unused nix store paths, as I would expect from a dry run. The code here means that if you pass the--dry-run
flag, it completely skips the entire body of the script and just returns 0.Steps To Reproduce
nix-collect-garbage --dry-run
nix-collect-garbage
Expected behavior
nix-collect-garbage --dry-run
should print the paths that would be deleted, and then not delete them.nix --version
outputnix (Lix, like Nix) 2.91.0-dev-pre20240704-d00edfb
Additional context
I'm not well versed in C++, but this seems like it should be a relatively easy fix. The GCOptions struct has a
gcReturnDead
action, which should return the list of paths that would be deleted instead of actually deleting them. It should be as simple as setting the action togcReturnDead
if thedryRun
flag is set, andgcDeleteDead
if it isn't.This issue was mentioned on Gerrit on the following CLs:
this has been fixed but wasn't auto-closed.