possible bug in ``Store::parseStorePath` #430

New issue

Closed

opened 2024-07-03 18:14:38 +00:00 by pennae · 1 comment

pennae commented

2024-07-03 18:14:38 +00:00

Owner

rapidcheck finally did something that wasn't crash:

lix> /nix/store/P2F1QIJI70D4RXAK0HG73SJL6WBJHMJ4-rapidcheck-0-unstable-2023-12-14-dev/include/rapidcheck/gtest.h:29: Failure
lix> Failed
lix> Falsifiable after 60 tests and 2 shrinks
lix> std::string:
lix> "0/"
lix> ../tests/unit/libstore/path.cc:152:
lix> RC_ASSERT(parsed == std::regex_match(std::string { name }, nameRegex))
lix> Expands to:
lix> true == false
lix> [  FAILED  ] StorePathTest_RapidCheck.prop_check_regex_eq_parse (1 ms)

this looks like a bug, but whether (and where) it is a bug may depend strongly on context.

[rapidcheck finally did something that wasn't crash](https://buildbot.lix.systems/#/builders/37/builds/2721/steps/1/logs/stdio): ``` lix> /nix/store/P2F1QIJI70D4RXAK0HG73SJL6WBJHMJ4-rapidcheck-0-unstable-2023-12-14-dev/include/rapidcheck/gtest.h:29: Failure lix> Failed lix> Falsifiable after 60 tests and 2 shrinks lix> std::string: lix> "0/" lix> ../tests/unit/libstore/path.cc:152: lix> RC_ASSERT(parsed == std::regex_match(std::string { name }, nameRegex)) lix> Expands to: lix> true == false lix> [ FAILED ] StorePathTest_RapidCheck.prop_check_regex_eq_parse (1 ms) ``` this looks like a bug, but whether (and *where*) it is a bug may depend strongly on context.