Split up `util.cc` #43

New issue

Closed

opened 2024-03-14 23:13:15 +00:00 by rbt · 5 comments

rbt commented

2024-03-14 23:13:15 +00:00

Owner

Every util should be in its own file.

cf https://programmingisterrible.com/post/139222674273/write-code-that-is-easy-to-delete-not-easy-to

Make a util directory and keep different utilities in different files. A single util file will always grow until it is too big and yet too hard to split apart. Using a single util file is unhygienic.

Every util should be in its own file. cf https://programmingisterrible.com/post/139222674273/write-code-that-is-easy-to-delete-not-easy-to > Make a util directory and keep different utilities in different files. A single util file will always grow until it is too big and yet too hard to split apart. Using a single util file is unhygienic.

jade commented

2024-03-15 01:55:05 +00:00

Owner

The grouping by area in upstream Nix is relatively reasonable. We didn't port the change directly because it was unreviewable, but I did do some parts of it.

jade added the

devx

label 2024-03-15 20:29:36 +00:00

jade referenced this issue

2024-05-08 08:09:36 +00:00

nix-du fails to build #275

jade commented

2024-05-08 08:10:32 +00:00

Owner

Action items to help: look at the commit upstream that splits util.hh, then grab one of the newly split files and go pull those items out of util.hh and util.cc into separate files. Do this one file per commit.

jade added the

E/easy

E/help wanted

labels 2024-05-08 08:10:38 +00:00

tom-hubrecht commented

2024-05-28 15:47:20 +00:00

I created https://gerrit.lix.systems/c/lix/+/1225/1 for this

jade commented

2024-05-29 22:59:58 +00:00

Owner

Thanks! I will review it and (contrary to normal practice) merge it myself, since I need to synchronize the push with a lix-nixos-module update and nix-eval-jobs update.