lix-project/lix

Fork 31

error: unsupported Git input attribute 'dir' #419

New issue

Closed

opened 2024-06-25 19:06:18 +00:00 by mweinelt · 6 comments

mweinelt commented

2024-06-25 19:06:18 +00:00

Member

Describe the bug

Entering a flake devshell in nixos/infra, e.g. https://github.com/NixOS/infra/tree/master/build or https://github.com/NixOS/infra/tree/master/non-critical-infra results in the following error:

$ nix develop
error: unsupported Git input attribute 'dir'

Steps To Reproduce

cd $(mktemp -d)
git clone https://github.com/nixos/infra
cd infra/build
nix develop

Expected behavior

Entering the devshell

`nix --version` output

nix (Lix, like Nix) 2.91.0-dev-pre20240624-d86009b

Additional context

Works with nix 2.18.2

## Describe the bug Entering a flake devshell in nixos/infra, e.g. https://github.com/NixOS/infra/tree/master/build or https://github.com/NixOS/infra/tree/master/non-critical-infra results in the following error: ``` $ nix develop error: unsupported Git input attribute 'dir' ``` ## Steps To Reproduce ``` cd $(mktemp -d) git clone https://github.com/nixos/infra cd infra/build nix develop ``` ## Expected behavior Entering the devshell ## `nix --version` output ``` nix (Lix, like Nix) 2.91.0-dev-pre20240624-d86009b ``` ## Additional context Works with nix 2.18.2

mweinelt added the

bug

label 2024-06-25 19:06:18 +00:00

pennae commented

2024-06-25 19:22:26 +00:00

Owner

probably broken by https://gerrit.lix.systems/c/lix/+/1102 (reverted in https://gerrit.lix.systems/c/lix/+/1523).

ma27 commented

2024-06-25 19:38:27 +00:00

Member

Fallout from https://gerrit.lix.systems/c/lix/+/1102. Should be fixed on master. Self-assigning because I'd like to sort out what has happened here when redoing the change.

EDIT: sorry pennae, your comment didn't appear until after I wrote mine 🙈

Fallout from https://gerrit.lix.systems/c/lix/+/1102. Should be fixed on master. Self-assigning because I'd like to sort out what has happened here when redoing the change. EDIT: sorry pennae, your comment didn't appear until after I wrote mine 🙈

ma27 self-assigned this 2024-06-25 19:38:33 +00:00

mweinelt commented

2024-06-25 19:42:44 +00:00

Author

Member

Can confirm it works on

nix (Lix, like Nix) 2.91.0-dev-pre20240625-c097ebe

Can confirm it works on ``` nix (Lix, like Nix) 2.91.0-dev-pre20240625-c097ebe ```

jade commented

2024-06-25 22:14:56 +00:00

Owner

oh awesome, thanks for finding a working reproducer through the cli! i submitted the revert last night.

jade commented

2024-07-13 14:19:29 +00:00

Owner

fixed in revert, closing

jade closed this issue

2024-07-13 14:19:29 +00:00

lix-bot commented

2024-07-28 13:40:44 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/1685 ("Reapply "libfetchers: make attribute / URL query handling consistent"")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/1685](https://gerrit.lix.systems/c/lix/+/1685) ("Reapply "libfetchers: make attribute / URL query handling consistent"")