Replace the flake URI "parsers" (regexes) with parsers #417

New issue

Open

opened 2024-06-24 22:37:49 +00:00 by jade · 0 comments

jade commented

2024-06-24 22:37:49 +00:00

Owner

These are completely busted, there is no way they are not full of bugs, and they are pretty well incomprehensible.

i would Not trust that parser as far as i can throw it

- @jade_:matrix.org, 2024-06-19

Thanks to @pennae putting pegtl in tree, we can start rewriting regexes as actual parsers.

These parsers have regressed before and they will regress again. Anyone proposing to fix these needs to fuzz them; this is absolutely mandatory given how absolutely scuffed they are.

flakeRegex: http://regexr.com/82215
pathUrlRegex: https://regexr.com/82218

The affected parsers are in parseFlakeRefWithFragment: 35eec921af/src/libexpr/flake/flakeref.cc (L72-L77)

These are completely busted, there is no way they are not full of bugs, and they are pretty well incomprehensible. > i would Not trust that parser as far as i can throw it \- @jade_:matrix.org, 2024-06-19 Thanks to @pennae putting pegtl in tree, we can start rewriting regexes as actual parsers. These parsers have regressed before and they will regress again. Anyone proposing to fix these needs to fuzz them; this is absolutely mandatory given how absolutely scuffed they are. flakeRegex: http://regexr.com/82215 pathUrlRegex: https://regexr.com/82218 The affected parsers are in `parseFlakeRefWithFragment`: https://git.lix.systems/lix-project/lix/src/35eec921af1043fc6322edc0ad88c872d41623b8/src/libexpr/flake/flakeref.cc#L72-L77