lix-project/lix

Fork

You've already forked lix

Code Issues 360 Code Review (Gerrit) Projects 3 Releases Wiki Activity

logger libutil test is completely commented out 💀 #416

New issue

Open

opened 2024-06-24 17:02:32 +00:00 by qyriad · 0 comments

qyriad commented

2024-06-24 17:02:32 +00:00

Owner

Copy link

Thanks to @alois31 for noticing this:

tests/unit/libutil/logging.cc

Line 1 in 4c3d936

#if 0

That entire file has been commented out with #if 0 for three years.

Thanks to @alois31 for noticing this: https://git.lix.systems/lix-project/lix/src/commit/4c3d93611f2848c56ebc69c85f2b1e18001ed3c7/tests/unit/libutil/logging.cc#L1 That entire file has been commented out with `#if 0` for three years.

🫠 1

qyriad added the

testing

bug

labels 2024-06-24 17:02:32 +00:00

No Branch/Tag specified

Branches Tags

main

release-2.91

sb/raito/phantom-referrers-gc

repl-overlay-example

reuse-compliance

release-2.90

git-series/activity-cleanup

sb/tom-hubrecht/primops.cc-v2

sb/bacchanalia/cache-strlen%topic=substr-perf

sb/arcuru/commit-msg

sb/qyriad/beta-1

sb/qyriad/2.90-beta.0

rbt/pre-commit-update

sb/rbt/test-branch

sb/rbt/justfile

sb/rbt/repl-overlays

sb/fuck/what

sb/rbt/pre-commit

sb/rbt/makeflags

sb/pennae/io-rewrite

sb/qyriad/maint-meson

sb/qyriad/maint/meson

sb/puck/meson-c-api

sb/pennae/parser-rewrite

sb/jade/burn-it-all

dependabot/github_actions/zeebe-io/backport-action-2.4.1

dependabot/github_actions/cachix/install-nix-action-25

dependabot/github_actions/actions/labeler-5

dependabot/github_actions/cachix/cachix-action-14

2.91.1

2.91.0

2.90.0

2.90.0-rc1

2.90-beta.1

2.90-beta.0

Labels

Clear labels

Area/build-packaging

regarding the building or packaging of Lix itself

Area/cli

The command line interface of Lix

Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

Area/flakes

Area/language

language design, features, extensions, etc

Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

Area/protocol

The protocol, used for communicating between the client and the daemon

libstore and anything else relating to the Nix store

bug

it's a bug

crash 💥

Lix crashes (possibly bad error handling)

Cross Compilation

devx

development experience issues

docs

requires or is about documentation changes

Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

E/easy

bug is relatively simple and could simply be fixed with some minor effort

E/hard

this issue should probably be solved with close involvement of an expert

E/help wanted

maintainers may not get to this soon, but we want it fixed

E/reproducible

This bug is reproducible and obvious.

E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

Needs Langver

We can't get to this until we implement language versioning

OS/Linux

Affects specifically Lix on Linux

OS/macOS

Affects specifically Lix on macOS

performance

make lix go faster

regression

This is a regression since some previous version of Lix

release-blocker

Blocks public release

RFD

Request for discussion

stability

Fixing this makes the software more stable

not our bug, duplicate, similar

Status

postponed

closed but should maybe look at later (generally with S-wontfix)

Status

wontfix

We chose not to change this (see issue comments for more detail).

testing

Tests that should be added

testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

makes the user experience better :)

No labels

Downstream Dependents

E/requires rearchitecture

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#416

Reference in a new issue

Repository

lix-project/lix

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?