refactor: make createTempDir take an optional for temp dir root #415

Open
opened 2024-06-24 08:20:40 +00:00 by jade · 2 comments
Owner

Noticed on https://gerrit.lix.systems/c/lix/+/1514 that we are using string emptiness as a signal of whether it should be the default name or not. We should fix this, that's a very sketchy way of doing optionality.

Noticed on https://gerrit.lix.systems/c/lix/+/1514 that we are using string emptiness as a signal of whether it should be the default name or not. We should fix this, that's a very sketchy way of doing optionality.
jade added the
stability
E/easy
E/help wanted
labels 2024-06-24 08:20:40 +00:00
Member

This issue was mentioned on Gerrit on the following CLs:

  • comment in cl/1514 ("Add build-dir setting, clean up default TMPDIR handling")
<!-- GERRIT_LINKBOT: {"cls": [{"backlink": "https://gerrit.lix.systems/c/lix/+/1514", "number": 1514, "kind": "comment"}], "cl_meta": {"1514": {"change_title": "Add build-dir setting, clean up default TMPDIR handling"}}} --> This issue was mentioned on Gerrit on the following CLs: * comment in [cl/1514](https://gerrit.lix.systems/c/lix/+/1514) ("Add build-dir setting, clean up default TMPDIR handling")

I've started working on this issue. I've got a branch that I think has accomplished the goal, but I want to self-review before putting it up for peer review.

I've started working on this issue. I've got a branch that I think has accomplished the goal, but I want to self-review before putting it up for peer review.
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#415
No description provided.