lix-project/lix
18
37
Fork 14
Code Issues 286 Code Review (Gerrit) Projects 1 Releases Wiki Activity

meson build system #41

New issue
Closed
opened 2024-03-14 22:52:58 +00:00 by rbt · 24 comments
rbt commented 2024-03-14 22:52:58 +00:00
Owner
Copy link

Use the Meson build system.

Use the Meson build system.
rbt added the
release-blocker
devx
 labels 2024-03-14 22:52:58 +00:00
rbt added this to the Meson migration project 2024-03-14 22:52:58 +00:00
puck commented 2024-03-14 23:31:22 +00:00
Owner
Copy link

@qyriad has been working on this: https://git.lix.systems/qyriad/lix/src/branch/maint/meson

@qyriad has been working on this: https://git.lix.systems/qyriad/lix/src/branch/maint/meson
qyriad self-assigned this 2024-03-15 03:34:11 +00:00
qyriad commented 2024-03-15 03:36:23 +00:00
Owner
Copy link

I've been chipping away at the different components of Lix, converting them to Meson; I have each of src/lib* building so far. It has been pretty straightforward, but I expect that the Perl bindings, docs, and tests will be where the real complexity will be

I've been chipping away at the different components of Lix, converting them to Meson; I have each of `src/lib*` building so far. It has been pretty straightforward, but I expect that the Perl bindings, docs, and tests will be where the real complexity will be
👍 1
jade modified the project from Meson migration to Release engineering 2024-03-18 22:05:47 +00:00
jade modified the project from Release engineering to Meson migration 2024-03-18 22:05:52 +00:00
jade added this to the v2.90 milestone 2024-03-18 22:18:36 +00:00
qyriad commented 2024-03-19 01:41:48 +00:00
Owner
Copy link

https://gerrit.lix.systems/c/lix/+/580 is pushed to Gerrit, which implements building and installing binaries and headers with Meson. Tests and docs incoming.

https://gerrit.lix.systems/c/lix/+/580 is pushed to Gerrit, which implements building and installing binaries and headers with Meson. Tests and docs incoming.
qyriad commented 2024-03-20 03:35:38 +00:00
Owner
Copy link

Update: the Meson build on macOS specifically is ending up with references to Boost in the closure, which is something we don't want (we explicitly copy the boost libs we need into $out/lib to avoid this), and is also a significant enough difference from the old build results that it needs investigation, so that's what we're working on debugging now.

Update: the Meson build on macOS specifically is ending up with references to Boost in the closure, which is something we don't want (we explicitly copy the boost libs we need into `$out/lib` to avoid this), and is also a significant enough difference from the old build results that it needs investigation, so that's what we're working on debugging now.
qyriad commented 2024-03-25 15:46:44 +00:00
Owner
Copy link

Update: the Boost rpath references in $out/lib were apparently "normal" — at least in the sense that the libs were not built differently than they should have been.

The old build system makes the interesting move to, at install-time, re-link libraries using $out/lib as the new library search path.

Meson doesn't have any notion of "making link targets that depend on install targets to then be installed", and since getting Boost out of the rpath is something we specifically want for the derivation that builds Lix, we opted to just patch the Mach-O instead, something that the derivation was already doing for libnixutil.dylib anyway.

So anyway. Building and installing were successfully added in b4d07656ff.

We're almost done with running the test suites in Meson too 🎉

Update: the Boost rpath references in `$out/lib` were apparently "normal" — at least in the sense that the libs were not built differently than they should have been. The old build system makes the interesting move to, at install-time, [re-link libraries](https://git.lix.systems/lix-project/lix/src/commit/d3d7489571baeb651d3843dba3b638621694c174/mk/libraries.mk#L111-L118) using `$out/lib` as the new library search path. Meson doesn't have any notion of "making link targets that depend on install targets to then be installed", and since getting Boost out of the rpath is something we specifically want for the derivation that builds Lix, we opted to just [patch the Mach-O instead](https://git.lix.systems/lix-project/lix/src/commit/d3d7489571baeb651d3843dba3b638621694c174/package.nix#L263-L268), something that the derivation was *already doing* for libnixutil.dylib anyway. So anyway. Building and installing were successfully added in b4d07656ff2c43b1144eb97658b9528dd39418ce. We're almost done with running the test suites in Meson too 🎉
gabriella439 commented 2024-03-25 15:50:41 +00:00
Owner
Copy link

Exciting!! Very nice work

Exciting!! Very nice work
lunaphied commented 2024-03-26 18:58:32 +00:00
Owner
Copy link

@qyriad I just did some local tests and for some reason if I run .#hydraJobs.mesonBuild.x86_64-linux on my local machine, it actually starts building the existing Makefile based system instead; if I remove the overrideAttrs bit that appends the original Nix invocation's buildInputs it actually uses Meson. This does not happen on my Mac

@qyriad I just did some local tests and for some reason if I run `.#hydraJobs.mesonBuild.x86_64-linux` on my local machine, it actually starts building the existing Makefile based system instead; if I remove the `overrideAttrs` bit that appends the original Nix invocation's `buildInputs` it actually uses Meson. This does not happen on my Mac
qyriad commented 2024-03-26 19:04:20 +00:00
Owner
Copy link

What the fuck

What the fuck
qyriad commented 2024-03-26 19:05:26 +00:00
Owner
Copy link

@lunaphied your local machine is x86_64-linux, yes?

@lunaphied your local machine is x86_64-linux, yes?
qyriad commented 2024-03-26 19:06:24 +00:00
Owner
Copy link

Just git pulled a536438da..007e6b580 and now seeing this o.o

Just git pulled `a536438da..007e6b580` and now seeing this o.o
lunaphied commented 2024-03-26 19:06:47 +00:00
Owner
Copy link

your local machine is x86_64-linux, yes?

The one I'm encountering this on is. I should also note that I encountered an inconsistency on aarch64-drawin, where when I added a Meson target identical to the existing hydraJob definitions but using the gccStdenv it used Clang anyway somehow, which does not happen with the equivalent for the Makefile based system

> your local machine is x86_64-linux, yes? The one I'm encountering this on is. I should also note that I encountered an inconsistency on aarch64-drawin, where when I added a Meson target identical to the existing hydraJob definitions but using the `gccStdenv` it used Clang anyway somehow, which does not happen with the equivalent for the Makefile based system
qyriad commented 2024-03-26 19:09:51 +00:00
Owner
Copy link

Reverting ad8a4b380e (cc @raito ) fixes this

…Somehow.

What.

Reverting ad8a4b380e83145c51b97fcd4a30038cf09e0ed1 (cc @raito ) fixes this …Somehow. What.
lunaphied commented 2024-03-26 19:10:23 +00:00
Owner
Copy link

... what

... *what*
pennae commented 2024-03-26 19:18:13 +00:00
Owner
Copy link

that's because linearizing the meson tests means that mesonBuild depends on build, and mesonBuildClang depens on mesonBuild. that's expected and only temporary to make ci not explode. you can remove the overrideAttrs in the meson hydra jobs for local tests.

that's because linearizing the meson tests means that mesonBuild depends on build, and mesonBuildClang depens on mesonBuild. that's expected and only temporary to make ci not explode. you can remove the overrideAttrs in the meson hydra jobs for local tests.
qyriad commented 2024-03-26 19:19:03 +00:00
Owner
Copy link

Right that would do that thank you

*Right that would do that* thank you
lunaphied commented 2024-03-26 19:19:44 +00:00
Owner
Copy link

I don't think that's the issue since reverting an unrelated PR fixed it. Also this have just the same issue in CI no? or is it bypassed because of the way nix-eval-jobs works?

I don't think that's the issue since reverting an unrelated PR fixed it. Also this have just the same issue in CI no? or is it bypassed because of the way `nix-eval-jobs` works?
qyriad commented 2024-03-26 19:20:51 +00:00
Owner
Copy link

@lunaphied it does build with Meson, it just builds with Meson after it builds with Make

@lunaphied it does build with Meson, it just builds with Meson after it builds with Make
lunaphied commented 2024-03-26 19:21:24 +00:00
Owner
Copy link

Ah okay. Very cursed. So the linked commit is unrelated?

Ah okay. Very cursed. So the linked commit is unrelated?
qyriad commented 2024-03-26 19:21:56 +00:00
Owner
Copy link

Yep

Yep
pennae commented 2024-03-26 19:22:14 +00:00
Owner
Copy link

if you revert that commit and the source set before the revert is cached the dep needs not be built. ci doesn't run into this because it builds a dag and doesn't even start the meson build before the non-meson build has finished.

if you revert that commit and the source set before the revert is cached the dep needs not be built. ci doesn't run into this because it builds a dag and doesn't even start the meson build before the non-meson build has finished.
qyriad commented 2024-03-26 19:27:34 +00:00
Owner
Copy link

Yep, exactly. Thank you @pennae and sorry for the confusion

Yep, exactly. Thank you @pennae and sorry for the confusion
qyriad commented 2024-04-17 21:55:51 +00:00
Owner
Copy link

With the merge of https://gerrit.lix.systems/c/lix/+/836, I…think the buildsystem itself is done? Now we just need to verify that meson outputs everything correctly, update development documentation to include meson instructions, and flip the buildWithMeson ? false to true switch in package.nix?

@pennae @jade that sound about right?

With the merge of https://gerrit.lix.systems/c/lix/+/836, I…think the buildsystem itself is done? Now we just need to verify that meson outputs everything correctly, update development documentation to include meson instructions, and flip the `buildWithMeson ? false` to `true` switch in `package.nix`? @pennae @jade that sound about right?
👍 1 :neofox_heart: 1
pennae commented 2024-04-17 22:03:34 +00:00
Owner
Copy link

sounds good. we made an attempt to verify that the meson binaries can be made bit-identical to the autoconf binaries with just some flag juggling, but that didn't lead anywhere. if anyfew with more patience for such nonsense wants to attempt we'd be very happy, otherwise we'll have to find the fuckups by testing :<

sounds good. we made an attempt to verify that the meson binaries can be made bit-identical to the autoconf binaries with just some flag juggling, but that didn't lead anywhere. if anyfew with more patience for such nonsense wants to attempt we'd be very happy, otherwise we'll have to find the fuckups by testing :<
qyriad commented 2024-04-26 00:44:54 +00:00
Owner
Copy link

As of b913a939b0, Meson is now the default buildsystem for Lix 🎉!

All that is left now is to remove the old buildsystem. I'm going to open a new issue for that.

As of b913a939b0aeccf979950f5dcb5089d565fee2a3, Meson is now the default buildsystem for Lix 🎉! All that is left now is to remove the old buildsystem. I'm going to open a new issue for that.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
git-series/activity-cleanup
release-2.90
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/flakes

   
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
Cross Compilation

   
devx

development experience issues

  
docs

   
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/evaluator
Area/flakes
Area/profiles
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
ux
Milestone
Clear milestone
No items
No milestone
v2.90
Projects
Clear projects
No items
No project
Meson migration
Assignees
Clear assignees
No assignees
qyriad
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#41
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?