pre-commit hook #40

New issue

Closed

opened 2024-03-14 22:52:14 +00:00 by rbt · 2 comments

rbt commented

2024-03-14 22:52:14 +00:00

Owner

Set up a pre-commit hook with:

Code formatting for Nix code (C++ code to come when we're done with backports)
Trailing whitespace checks
Newline-at-end-of-file checks
"include what you use"

Set up a `pre-commit` hook with: - Code formatting for Nix code (C++ code to come when we're done with backports) - Trailing whitespace checks - Newline-at-end-of-file checks - "include what you use"

rbt added the

release-blocker

devx

labels 2024-03-14 22:52:14 +00:00

jade added this to the v2.90 milestone 2024-03-18 22:18:36 +00:00

jade added this to the Release engineering project 2024-03-24 06:24:58 +00:00

pennae commented

2024-03-26 13:19:43 +00:00

Owner

only the middle two seem at all realistic at this point; auto-formatting parts of files on commit should be possible but would create a pretty bad mess very quickly without prior reformatting of the entire codebase. iwyu might be plausible to add once it has been applied though (and might bring down compile times even further?)