Make the revisionSuffix bit a specialization step *after* the expensive build so you don't get excess rebuilds while working on repo nix infra #384
Labels
No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: lix-project/lix#384
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It's very goofy that you get Lix rebuilds while poking at things in the repo that aren't Lix, which are caused by revisionSuffix changing to -dirty, e.g. This should be fixed so that the Lix derivation gets fixed up. Ideally we also deal with self-references and replace them correctly by some means, perhaps objcopy into a purpose-made section for self-references.
Then the specialization step would just be: copy all the bins over and forbid references to the original output path, then objcopy in the version information.
Sure, you can force officialRelease = true, which fixes this temporarily, but we could do this cleanly instead.