__json can be invalid without the daemon rejecting the derivation, then fails at build #380

New issue

Open

opened 2024-06-07 22:04:19 +00:00 by jade · 0 comments

jade commented

2024-06-07 22:04:19 +00:00

Owner

cc @puck

initially i was thinking we shouldn't accept people putting __json into derivations at all, but I'm not so sure now. i think that has possible valid use cases like wanting to serialize it in another process and avoid a round trip, perhaps, but we could certainly just outright reject derivations with bad __json as invalid at the daemon, assuming that uh we actually have any checks on those and they're not just like, sent over as bytes as it currently stands.

cc @puck initially i was thinking we shouldn't accept people putting `__json` into derivations at all, but I'm not so sure now. i think that has possible valid use cases like wanting to serialize it in another process and avoid a round trip, perhaps, but we could certainly just outright reject derivations with bad `__json` as invalid at the daemon, assuming that uh we actually have any checks on those and they're not just like, sent over as bytes as it currently stands.

jade added the

stability

label 2024-06-07 22:04:19 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#380

No description provided.