lix-project/lix
17
37
Fork 14
Code Issues 286 Code Review (Gerrit) Projects 1 Releases Wiki Activity

Build fails in single-user mode because install tests fail #365

New issue
Closed
opened 2024-05-31 17:36:13 +00:00 by alois31 · 4 comments
alois31 commented 2024-05-31 17:36:13 +00:00
Member
Copy link

Describe the bug

When trying to build recent versions of Lix using the Nix packaging in single-user mode, there are a lot of test failures in the installCheckPhase.

Steps To Reproduce

  1. Check out commit ff08d95420 (latest as of time of writing).
  2. Run nix-build -A packages.x86_64-linux.nix --store [some directory].
  3. Observe that during the installCheckPhase, most tests fail with error: home directory '/homeless-shelter' exists; please remove it to assure purity of builds without sandboxing.

Expected behavior

The build succeeds.

nix --version output

nix (Lix, like Nix) 2.90.0-pre0381aacff0be

Additional context

On b6799ab037 (2.90-beta.1), the build succeeds. I'm currently running another bisect because the first result was garbage.

## Describe the bug When trying to build recent versions of Lix using the Nix packaging in single-user mode, there are a lot of test failures in the installCheckPhase. ## Steps To Reproduce 1. Check out commit ff08d954206a557ec7afe7301cdb4bb72114875f (latest as of time of writing). 2. Run `nix-build -A packages.x86_64-linux.nix --store [some directory]`. 3. Observe that during the installCheckPhase, most tests fail with `error: home directory '/homeless-shelter' exists; please remove it to assure purity of builds without sandboxing`. ## Expected behavior The build succeeds. ## `nix --version` output nix (Lix, like Nix) 2.90.0-pre0381aacff0be ## Additional context On b6799ab0374a8e1907a48915d3187e07da41d88c (2.90-beta.1), the build succeeds. I'm currently running another bisect because the first result was garbage.
alois31 added the
bug
 label 2024-05-31 17:36:13 +00:00
jade commented 2024-05-31 18:01:27 +00:00
Owner
Copy link

Thanks for debugging this! Single user mode on Linux is a kind of bad configuration that I regret that we support but we definitely shouldn't regress it accidentally; honestly it ought to be made to perform identically to multi user because that should be possible. Interested to find the results of your debugging.

Thanks for debugging this! Single user mode on Linux is a kind of bad configuration that I regret that we support but we definitely shouldn't regress it accidentally; honestly it *ought* to be made to perform identically to multi user because that *should* be possible. Interested to find the results of your debugging.
alois31 commented 2024-05-31 19:55:05 +00:00
Author
Member
Copy link

According to the bisect, 0565f97e78 is the first bad commit (which still seems a bit weird). FWIW, the first result gave 677cf75473, which is the commit right before that, so there may be some nondeterminism involved.

According to the bisect, 0565f97e78f9ebd97849f79a3327f51e2157fc53 is the first bad commit (which still seems a bit weird). FWIW, the first result gave 677cf75473d0dd86119c4535d8733a6a0b1100c0, which is the commit right before that, so there may be some nondeterminism involved.
alois31 commented 2024-06-01 04:47:25 +00:00
Author
Member
Copy link

Reverting 0565f97e78 does in fact "fix" the build.

Reverting 0565f97e78f9ebd97849f79a3327f51e2157fc53 does in fact "fix" the build.
:neocat_scream_scared: 1
lix-bot commented 2024-06-03 09:08:49 +00:00
Member
Copy link

This issue was mentioned on Gerrit on the following CLs:

  • commit message in cl/1368 ("tests/libcmd: set HOME to a temporary directory")
<!-- GERRIT_LINKBOT: {"cls": [{"backlink": "https://gerrit.lix.systems/c/lix/+/1368", "number": 1368, "kind": "commit message"}], "cl_meta": {"1368": {"change_title": "tests/libcmd: set HOME to a temporary directory"}}} --> This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/1368](https://gerrit.lix.systems/c/lix/+/1368) ("tests/libcmd: set HOME to a temporary directory")
alois31 reopened this issue 2024-06-04 06:27:31 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
git-series/activity-cleanup
release-2.90
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/flakes

   
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
Cross Compilation

   
devx

development experience issues

  
docs

   
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/evaluator
Area/flakes
Area/profiles
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#365
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?