lix-project/lix
19
98
Fork 71
Code Issues 550 Code Review (Gerrit) Projects 8 Releases Packages Wiki Activity

Write test fixturing for libfetchers #363

New issue
Open
opened 2024-05-30 21:30:15 +00:00 by jade · 4 comments
jade commented 2024-05-30 21:30:15 +00:00
Owner
Copy link

Steps:

Move the serveHTTP infrastructure from

Lines 29 to 30 in 285bc67
static std::tuple<uint16_t, AutoCloseFD>
serveHTTP(std::vector<Reply> replies)

into a .cc file in libutil-support instead and add a header, then bring up a libfetchers unit test suite using the http server in a similar way as tests/unit/libstore/filetransfer.cc.

Steps: Move the serveHTTP infrastructure from https://git.lix.systems/lix-project/lix/src/commit/285bc67318e2ee4b69b13eb0b8e7b202fc287c51/tests/unit/libstore/filetransfer.cc#L29-L30 into a .cc file in libutil-support instead and add a header, then bring up a libfetchers unit test suite using the http server in a similar way as tests/unit/libstore/filetransfer.cc.
pennae commented 2024-05-30 21:36:41 +00:00
Owner
Copy link

actually. can we do one better and include libmicrohttpd or something that's actually an http server? serveHTTP is already grown perhaps a bit too far, and testing actual fetchers might need a lot more still?

actually. can we do one better and include libmicrohttpd or something that's *actually an http server*? `serveHTTP` is already grown perhaps a bit too far, and testing actual fetchers might need a lot more still?
jade commented 2024-05-30 21:40:52 +00:00
Author
Owner
Copy link

yeah, we probably should just do that. i have also abused python http.server elsewhere as an http server that's already in our closure. microhttpd would also be extremely reasonable for the c++ side. i would be fine with either approach, either doing it in c++ or doing the fake apis in python.

yeah, we probably should just do that. i have also abused python http.server elsewhere as an http server that's already in our closure. microhttpd would also be extremely reasonable for the c++ side. i would be fine with either approach, either doing it in c++ or doing the fake apis in python.
jade commented 2024-05-31 19:24:09 +00:00
Author
Owner
Copy link

stuff like https://gerrit.lix.systems/c/lix/+/1363 is just goofy and we would like to make it easier to get it right in the future

stuff like https://gerrit.lix.systems/c/lix/+/1363 is just goofy and we would like to make it easier to get it right in the future
❤️ 1
rootile added this to the functional2 project 2025-12-23 17:01:42 +00:00
rootile commented 2025-12-23 17:03:29 +00:00
Member
Copy link

note the unfinished existence of https://git.lix.systems/lix-project/lix/src/branch/main/tests/functional2/testlib/fixtures/http_server.py which can be expaned for this issue

note the unfinished existence of https://git.lix.systems/lix-project/lix/src/branch/main/tests/functional2/testlib/fixtures/http_server.py which can be expaned for this issue
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.94
release-2.95
ci-config
release-2.93
sb/jade/coverage
sb/raitobezarius/cgroups-observability
sb/jade/wip-tars
sb/raito/flakes-out-of-core
sb/raito/eval-explorations
sb/pennae/ci-config
release-2.91
release-2.92
sb/raito/darwin-kqueue-disablement
sb/raito/hydra-merge
sb/raito/phantom-referrers-gc
repl-overlay-example
reuse-compliance
release-2.90
sb/pennae/io-rewrite
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.95.3
2.93.4
2.94.2
2.95.2
2.95.1
2.94.1
2.95.0
2.94.0
2.93.3
2.92.3
2.93.2
2.91.3
2.92.2
2.91.2
2.93.1
2.93.0
2.92.0
2.91.1
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
1.11.1
1.11
1.10
1.9
1.8
1.7
1.6.1
1.6
1.5.3
1.5.2
1.5.1
1.5
1.4
1.3
1.2
1.1
1.0
Labels
Clear labels   
Affects/CppNix
Probably affects CppNix. This is a best-effort tag for troubles in old code; it exists to inform the CppNix team about problems they might care about also.

  
Affects/Nightly
Found in Lix nightly.

  
Affects/Only nightly
Tag for regressions in Lix nightly. We intend to fix all of these prior to releases.

  
Affects/Stable
Affects the stable release of Lix. Usually such issues affect nightly too but there is no guarantee.

  
Area/build-packaging
regarding the building or packaging of Lix itself

  
Area/cli
The command line interface of Lix

  
Area/evaluator
libexpr and anything else related to the evaluation of Nix expressions

  
Area/fetching
Fetching sources or other materials from the World Wide Web in Lix

  
Area/flakes

   
Area/language
language design, features, extensions, etc

  
Area/lix ci
Lix's own CI and deployment pipeline

  
Area/nix-eval-jobs
nix-eval-jobs for Lix

  
Area/profiles
profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol
The protocol, used for communicating between the client and the daemon

  
Area/releng
Release engineering

  
Area/remote-builds
remote builds

  
Area/repl
nix repl

  
Area/repl/debugger
The --debugger that brings up a Lix repl

  
Area/store
libstore and anything else relating to the Nix store

  
awaiting
author
 needs more information from the issue author

  
awaiting
contributors
 needs more information from contributors

  
bug
it's a bug

  
Context
contributors
 This issue might require some context that isn't written down. It might be possible to handle as a person who already worked on this area.

  
Context
drive-by
 This issue contains all the necessary information to do a drive-by contribution: that is, you don't have to talk with anyone at all to successfully solve it!

  
Context
maintainers
 This issue requires a lot of know-how. Attention from maintainers is needed to proceed.

  
Context
RFD
 This issue needs discussion from multiple maintainers and interested parties: it's a Request For Discussion.

  
crash 💥
Lix crashes (possibly bad error handling)

  
Cross Compilation

   
devx
development experience issues

  
diagnostics
Misleading error messages and the like

  
docs
requires or is about documentation changes

  
Downstream Dependents
regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy
bug is relatively simple and could simply be fixed with some minor effort

  
E/hard
this issue should probably be solved with close involvement of an expert

  
E/help wanted
maintainers may not get to this soon, but we want it fixed

  
E/reproducible
This bug is reproducible and obvious.

  
E/requires rearchitecture
this bug cannot be fixed properly without fixing a known architectural flaw

  
Feature/S3
S3 support in Lix

  
Importance
High
 Very important to Lix's goals, not to be confused with urgent

  
Importance
Low
 Less vital to Lix's goals. Not to be confused with non-urgent

  
imported
Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Infrastructure
This is about creating new infrastructure that will serve the Lix project.

  
Language/Bash

   
Language/C++

   
Language/NixLang

   
Language/Python

   
Language/Rust

   
Needs Langver
We can't get to this until we implement language versioning

  
OS/Linux
Affects specifically Lix on Linux

  
OS/macOS
Affects specifically Lix on macOS

  
performance
make lix go faster

  
regression
This is a regression since some previous version of Lix

  
Release Blocking
Non-urgent
 We can't finish a release without this, but HEAD is okay

  
Release Blocking
Urgent
 Disruptive AND blocking release. Something must be done!

  
stability
Fixing this makes the software more stable

  
Status
blocked
 Blocked on something

  
Status
invalid
 not our bug, duplicate, similar

  
Status
postponed
 closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
 We chose not to change this (see issue comments for more detail).

  
testing
Tests that should be added

  
testing/flakey
Tests that are unreliable/flakey (not to be confused with flakes that test)

  
Topic/Large Scale Installations
Large scale installations of Lix, e.g. NixOS Hydra, Lix CI, big corporate installations etc.

  
Urgency
High
 Disruptive and needs addressing quickly

  
Urgency
Low
 Does not require *immediate* attention

  
ux
makes the user experience better :)

No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
diagnostics
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Infrastructure
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
functional2
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lix-project/lix#363
No description provided.