Completion for commands (starting with ":") in repl #361

New issue

Closed

opened 2024-05-30 04:17:59 +00:00 by aleksanaa · 4 comments

aleksanaa commented

2024-05-30 04:17:59 +00:00

When typing : in nix repl and pressing tab, the completion is the same with not typing anything and pressing tab, instead of a list of available commands. When typing :lo and pressing tab, nothing happens.

Describe the solution you'd like

Completions for these commands appear when prefixed with :

Describe alternatives you've considered

Not displaying completion of any commands?

Additional context

I've opened an issue in https://github.com/NixOS/nix/issues/10509 but since I want to give lix a try, I'd like to also opening an issue here to see if I can get a response.

## Is your feature request related to a problem? Please describe. When typing `:` in `nix repl` and pressing tab, the completion is the same with not typing anything and pressing tab, instead of a list of available commands. When typing `:lo` and pressing tab, nothing happens. ## Describe the solution you'd like Completions for these commands appear when prefixed with `:` ## Describe alternatives you've considered Not displaying completion of any commands? ## Additional context I've opened an issue in https://github.com/NixOS/nix/issues/10509 but since I want to give lix a try, I'd like to also opening an issue here to see if I can get a response.

jade added the

Area/repl

labels

2024-05-30 07:10:38 +00:00

qyriad commented

2024-05-30 18:45:54 +00:00

Owner

This shouldn't be too hard. The : commands currently are hardcoded (lol) in src/libcmd/repl.cc in NixRepl::processLine(). We just need to shove the list of possible colon commands in NixRepl::completePrefix() in src/libcmd/repl.cc behind a prefix.starts_with(":")

We are currently working on #306, but can tackle this after because this should really be a thing

This shouldn't be too hard. The `:` commands currently are hardcoded (lol) in `src/libcmd/repl.cc` in `NixRepl::processLine()`. We just need to shove the list of possible colon commands in `NixRepl::completePrefix()` in `src/libcmd/repl.cc` behind a `prefix.starts_with(":")` We are currently working on https://git.lix.systems/lix-project/lix/issues/306, but can tackle this after because this should really be a thing

qyriad added the

E/easy

label

2024-05-30 18:45:59 +00:00

jade commented

2024-05-30 19:31:49 +00:00

Owner

we would love if there were a registry of repl commands, which would make this easier.

qyriad commented

2024-06-01 00:24:05 +00:00

Owner

https://gerrit.lix.systems/c/lix/+/1367

qyriad self-assigned this

2024-06-01 00:30:00 +00:00

lix-bot commented

2024-06-03 08:28:18 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/1367 ("repl: implement tab completing :colon commands")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/1367](https://gerrit.lix.systems/c/lix/+/1367) ("repl: implement tab completing :colon commands")