timeout.sh test is busted #355

New issue

Closed

opened 2024-05-26 15:09:31 +00:00 by pennae · 1 comment

pennae commented

2024-05-26 15:09:31 +00:00

Owner

apparently something was refactored once and broke the functional-timeout test in ways that did not make the test fail because bash is a horrid testing framework:

if echo "$messages" | grepQuietInvert "timed out"; then
    echo "error: build may have failed for reasons other than timeout; output:"
    echo "$messages" >&2
    exit 1
fi

succeeds even when it's supposed to fail because

error: building of '\''/tmp/nix-shell.WepHjG/nix-test/timeout/store/qssnbllilkb5ijivmz13s96jvjd775ch-timeout.drv^out'\'' from .drv file timed out after 2 seconds'
+(timeout.sh:15) grepQuietInvert 'timed out'
timeout.sh: line 15: grepQuietInvert: command not found

apparently something was refactored once and broke the `functional-timeout` test in ways that did not make the test fail because bash is a horrid testing framework: ``` if echo "$messages" | grepQuietInvert "timed out"; then echo "error: build may have failed for reasons other than timeout; output:" echo "$messages" >&2 exit 1 fi ``` succeeds even when it's supposed to fail because ``` error: building of '\''/tmp/nix-shell.WepHjG/nix-test/timeout/store/qssnbllilkb5ijivmz13s96jvjd775ch-timeout.drv^out'\'' from .drv file timed out after 2 seconds' +(timeout.sh:15) grepQuietInvert 'timed out' timeout.sh: line 15: grepQuietInvert: command not found ```