nix-shell shebangs run shellHook from outer shell?! #344

New issue

Open

opened 2024-05-23 20:44:24 +00:00 by jade · 3 comments

jade commented

2024-05-23 20:44:24 +00:00

Owner

#!/usr/bin/env nix-shell
#!nix-shell -i python3 -p 'python3.withPackages (ps: [ ps.requests ])'

This should never happen, goodness gracious. If you run from inside a nix shell that has a shellHook, it will run the shellHook again in the complete wrong context. When processing a shebang imo you should Just Not Use The shellHook.

lix/lix-nixos-module » ./update_pins.py
Hey there!

If you're thinking of working on Lix, please consider talking to us about it!
You should be aware that we are not accepting major features without some condi
tions,
and we highly recommend looking at our freeze status page on the wiki:
  https://wiki.lix.systems/books/lix-contributors/page/freezes-and-recommended-
contributions

We also have an overview of the codebase at
  https://wiki.lix.systems/books/lix-contributors/page/codebase-overview,
and other helpful information on the wiki.

But above all else, we want to hear from you!
We can help you figure out where in the codebase to look for whatever you want 
to do,
and we'd like to work together with all contributors as much as possible.
Lix is a collaborative project :)

You can open an issue at https://git.lix.systems/lix-project/lix/issues
or chat with us on Matrix: #space:lix.systems.

(Run `touch .nocontribmsg` to hide this message.)

Immediate action item: fix the Lix shellHook to check the workdir is actually Lix.

``` #!/usr/bin/env nix-shell #!nix-shell -i python3 -p 'python3.withPackages (ps: [ ps.requests ])' ``` This should never happen, goodness gracious. If you run from inside a nix shell that has a shellHook, it will run the shellHook again in the complete wrong context. When processing a shebang imo you should Just Not Use The shellHook. ``` lix/lix-nixos-module » ./update_pins.py Hey there! If you're thinking of working on Lix, please consider talking to us about it! You should be aware that we are not accepting major features without some condi tions, and we highly recommend looking at our freeze status page on the wiki: https://wiki.lix.systems/books/lix-contributors/page/freezes-and-recommended- contributions We also have an overview of the codebase at https://wiki.lix.systems/books/lix-contributors/page/codebase-overview, and other helpful information on the wiki. But above all else, we want to hear from you! We can help you figure out where in the codebase to look for whatever you want to do, and we'd like to work together with all contributors as much as possible. Lix is a collaborative project :) You can open an issue at https://git.lix.systems/lix-project/lix/issues or chat with us on Matrix: #space:lix.systems. (Run `touch .nocontribmsg` to hide this message.) ``` Immediate action item: fix the Lix shellHook to check the workdir is actually Lix.

❤️ 1