Replace the regex with something consistent cross-platform #34

Open
opened 2024-03-14 20:17:53 +00:00 by jade · 4 comments
Owner

Perhaps fork rust regex or such. Whatever we want. Currently the regexes are not the same cross platform, which is hilarious.

Perhaps fork rust `regex` or such. Whatever we want. Currently the regexes are not the same cross platform, which is hilarious.
jade added the
stability
label 2024-03-14 20:17:53 +00:00
Owner

Wait does Lix not use Boost regex? Or is Boost regex seriously not cross-platform?

Wait does Lix not use Boost regex? Or is Boost regex seriously not cross-platform?
Author
Owner

Wait does Lix not use Boost regex? Or is Boost regex seriously not cross-platform?

I don't know. All I know is there's been language visible differences in regex behaviour across platforms which is ridiculous. It may have been fixed since?

> Wait does Lix not use Boost regex? Or is Boost regex seriously not cross-platform? I don't know. All I know is there's been language visible differences in regex behaviour across platforms which is *ridiculous*. It may have been fixed since?
Author
Owner

Oh no I found cursed information in my signal history: @rbt:

they tried to replace it with boost but had to revert it because it wasn’t compatible with the regex escaper in NIXPKGS

NOOOOOO

well. ok. this means we have to have a custom regex implementation or just vendor the glibc one. but std::regex is terrible as I recall.

Oh no I found cursed information in my signal history: @rbt: > they tried to replace it with boost but had to revert it because it wasn’t compatible with the regex escaper in NIXPKGS NOOOOOO well. ok. this means we have to have a custom regex implementation or just vendor the glibc one. but std::regex is terrible as I recall.
Author
Owner

i think there's three solutions here: 

  • go find if someone packaged libc++ regex, vendor it
  • hack rust regex into being compatible with the status quo, vendor it
  • delete features from boost regex until it is soundly escaped by nixpkgs, vendor it
i think there's three solutions here:  * go find if someone packaged libc++ regex, vendor it * hack rust regex into being compatible with the status quo, vendor it * delete features from boost regex until it is soundly escaped by nixpkgs, vendor it
jade added this to the Broken regexes project 2024-06-24 23:47:42 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#34
No description provided.