lix-project/lix

Fork 31

Delete compatibility for daemons older than 2.3 #325

New issue

Closed

opened 2024-05-18 04:12:58 +00:00 by jade · 5 comments

jade commented

2024-05-18 04:12:58 +00:00

Owner

This is beyond any reasonable compatibility window (5 years), and if you want to build against a very old nix daemon, simply get an older nix client.

Nix 2.3 is version 21. Any versions strictly less than 21 can be dropped with reckless abandon, and we can fail at the start of the connection.

https://github.com/NixOS/nix/blob/2.3/src/libstore/worker-protocol.hh#L9

This is beyond any reasonable compatibility window (5 years), and if you want to build against a very old nix daemon, simply get an older nix client. Nix 2.3 is version *21*. Any versions strictly less than 21 can be dropped with reckless abandon, and we can fail at the start of the connection. https://github.com/NixOS/nix/blob/2.3/src/libstore/worker-protocol.hh#L9

jade added the

stability

E/easy

E/help wanted

labels 2024-05-18 04:12:58 +00:00

jade referenced this issue

2024-05-18 04:13:06 +00:00

"path (...) is not valid" is a highly non-descriptive error and doesn't say anything about what is corrupted if anything #270

pennae commented

2024-05-18 14:48:09 +00:00

Owner

we'd actually like to drop 2.3 too. and there's more to it than building against an old daemon, we also won't be able to build against a new daemon with an old client any more (both of which should be non-issues with how old nix 2.3 already is, and iwrc nixpkgs doesn't even fully work with 2.3 any more? at least we remember @puck saying something to that effect)

we'd actually like to drop 2.3 too. and there's more to it than building against an old daemon, we also won't be able to build against a *new* daemon with an old client any more (both of which should be non-issues with how old nix 2.3 already is, and iwrc nixpkgs doesn't even fully work with 2.3 any more? at least we remember @puck saying something to that effect)

pennae commented

2024-05-18 16:12:55 +00:00

Owner

cf https://gerrit.lix.systems/c/lix/+/1162; interop between <=2.0 and >=2.17 is just broken

qyriad added the

Area/store

label 2024-05-18 18:53:42 +00:00

lix-project referenced this issue from a commit

2024-05-19 12:43:39 +00:00

libstore: fix old RemoteStore::addToStore serializer

jade self-assigned this 2024-05-24 02:32:28 +00:00

jade referenced this issue from a commit

2024-05-25 02:23:24 +00:00

libstore: refuse to serialise ancient protocols

lix-bot commented

2024-06-03 09:55:15 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/1207 ("libstore: refuse to serialise ancient protocols")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/1207](https://gerrit.lix.systems/c/lix/+/1207) ("libstore: refuse to serialise ancient protocols")

jade commented

2024-06-15 03:09:32 +00:00

Author

Owner

Another thing we can delete is HasSubstitutes, since it is not used by anything except compatibility code for ancient versions of Nix that didn't have a list-based querySubstitutablePaths. Found when looking at #394

Another thing we can delete is `HasSubstitutes`, since it is not used by anything except compatibility code for ancient versions of Nix that didn't have a list-based querySubstitutablePaths. Found when looking at https://git.lix.systems/lix-project/lix/issues/394

lix-project referenced this issue from a commit

2024-06-17 22:09:10 +00:00

libstore: refuse to serialise ancient protocols

lix-project closed this issue

2024-06-17 22:09:10 +00:00

jade commented

2024-06-18 05:19:59 +00:00

Author

Owner

Follow-up CL deleting even more such code: https://gerrit.lix.systems/c/lix/+/1479

jade added the

Area/protocol