Fix blatantly broken daemon version detection code in testsuite #324

New issue

Closed

opened 2024-05-18 04:05:19 +00:00 by jade · 3 comments

jade commented

2024-05-18 04:05:19 +00:00

Owner

Stop parsing nix --version output ;-; wowie

This version pulling returns "like", which is uhhh veeeery wrong.

 isDaemonNewer () {
   [[ -n "${NIX_DAEMON_PACKAGE:-}" ]] || return 0
   local requiredVersion="$1"
   local daemonVersion=$($NIX_DAEMON_PACKAGE/bin/nix daemon --version | cut -d' ' -f3)
   [[ $(nix eval --expr "builtins.compareVersions ''$daemonVersion'' ''$requiredVersion''") -ge 0 ]]
 }

Stop parsing nix --version output ;-; wowie This version pulling returns "like", which is uhhh veeeery wrong. https://git.lix.systems/lix-project/lix/src/commit/e9ca5c92d2b3fdda27ff194869268562c237b043/tests/functional/common/vars-and-functions.sh.in#L146-L151

jade added the

labels 2024-05-18 04:05:19 +00:00

lunaphied commented

2024-05-18 04:06:46 +00:00

Owner

Hang on, how is this currently not causing CI to fail??

lunaphied closed this issue

2024-05-18 04:06:46 +00:00

lunaphied reopened this issue

2024-05-18 04:06:48 +00:00

jade commented

2024-05-18 04:07:42 +00:00

Author

Owner

dont wanna know, this code is totally hosed.

dont wanna know, this code is *totally* hosed.

lix-bot commented

2024-06-10 22:43:49 +00:00

Member

This issue was mentioned on Gerrit on the following CLs:

commit message in cl/1417 ("tests: fix daemon version in isDaemonNewer function")

This issue was mentioned on Gerrit on the following CLs: * commit message in [cl/1417](https://gerrit.lix.systems/c/lix/+/1417) ("tests: fix daemon version in isDaemonNewer function")