lix-project/lix
18
37
Fork 14
Code Issues 286 Code Review (Gerrit) Projects 1 Releases Wiki Activity

nix-prefetch-url regresses with commit 121edecf (no decompression) #300

New issue
Closed
opened 2024-05-11 11:52:18 +00:00 by delroth · 2 comments
delroth commented 2024-05-11 11:52:18 +00:00
Member
Copy link

Describe the bug

Starting from commit 121edecf65 nix-prefetch-url does not decompress files that have a gzip Content-Encoding before placing them in the store.

This was reported earlier today by @k900 on #dev:lix.systems and I was able to confirm it and bisect it.

Steps To Reproduce

  1. nix-prefetch-url https://github.com/NixOS/nixpkgs/pull/310287.diff
  2. Run file on the stored path.

Expected behavior

unified diff output, ASCII text and not gzip compressed data

nix --version output

(irrelevant, confirmed regressing in 121edecf65)

Additional context

n/a

## Describe the bug Starting from commit 121edecf654ec084274ba1a779c7140082f4115d `nix-prefetch-url` does not decompress files that have a `gzip` Content-Encoding before placing them in the store. This was reported earlier today by @k900 on #dev:lix.systems and I was able to confirm it and bisect it. ## Steps To Reproduce 1. `nix-prefetch-url https://github.com/NixOS/nixpkgs/pull/310287.diff` 2. Run `file` on the stored path. ## Expected behavior `unified diff output, ASCII text` and not `gzip compressed data` ## `nix --version` output (irrelevant, confirmed regressing in 121edecf654ec084274ba1a779c7140082f4115d) ## Additional context n/a
delroth added the
bug
 label 2024-05-11 11:52:18 +00:00
pennae was assigned by delroth 2024-05-11 11:52:18 +00:00
delroth commented 2024-05-11 12:11:10 +00:00
Author
Member
Copy link

https://gerrit.lix.systems/c/lix/+/1098

https://gerrit.lix.systems/c/lix/+/1098
delroth self-assigned this 2024-05-11 12:11:15 +00:00
delroth commented 2024-05-11 13:24:07 +00:00
Author
Member
Copy link

Fixed in 38d825b21e. I have a pending changeset (https://gerrit.lix.systems/c/lix/+/1099/1) adding a unit test which would have caught this.

Fixed in 38d825b21e425b0f0a64304ff5bfe4dfbeaf9e97. I have a pending changeset (https://gerrit.lix.systems/c/lix/+/1099/1) adding a unit test which would have caught this.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
git-series/activity-cleanup
release-2.90
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/flakes

   
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
Cross Compilation

   
devx

development experience issues

  
docs

   
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/evaluator
Area/flakes
Area/profiles
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
pennae
delroth
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#300
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?