lix-project/lix

Fork 31

nix-prefetch-url regresses with commit `121edecf` (no decompression) #300

New issue

Closed

opened 2024-05-11 11:52:18 +00:00 by delroth · 2 comments

delroth commented

2024-05-11 11:52:18 +00:00

Member

Describe the bug

Starting from commit 121edecf65 nix-prefetch-url does not decompress files that have a gzip Content-Encoding before placing them in the store.

This was reported earlier today by @k900 on #dev:lix.systems and I was able to confirm it and bisect it.

Steps To Reproduce

nix-prefetch-url https://github.com/NixOS/nixpkgs/pull/310287.diff
Run file on the stored path.

Expected behavior

unified diff output, ASCII text and not gzip compressed data

`nix --version` output

(irrelevant, confirmed regressing in 121edecf65)

Additional context

n/a

## Describe the bug Starting from commit 121edecf654ec084274ba1a779c7140082f4115d `nix-prefetch-url` does not decompress files that have a `gzip` Content-Encoding before placing them in the store. This was reported earlier today by @k900 on #dev:lix.systems and I was able to confirm it and bisect it. ## Steps To Reproduce 1. `nix-prefetch-url https://github.com/NixOS/nixpkgs/pull/310287.diff` 2. Run `file` on the stored path. ## Expected behavior `unified diff output, ASCII text` and not `gzip compressed data` ## `nix --version` output (irrelevant, confirmed regressing in 121edecf654ec084274ba1a779c7140082f4115d) ## Additional context n/a

delroth added the

bug

label 2024-05-11 11:52:18 +00:00

pennae was assigned by delroth

2024-05-11 11:52:18 +00:00

delroth commented

2024-05-11 12:11:10 +00:00

Author

Member

https://gerrit.lix.systems/c/lix/+/1098

delroth self-assigned this 2024-05-11 12:11:15 +00:00

delroth commented

2024-05-11 13:24:07 +00:00

Author

Member

Fixed in 38d825b21e. I have a pending changeset (https://gerrit.lix.systems/c/lix/+/1099/1) adding a unit test which would have caught this.

Fixed in 38d825b21e425b0f0a64304ff5bfe4dfbeaf9e97. I have a pending changeset (https://gerrit.lix.systems/c/lix/+/1099/1) adding a unit test which would have caught this.

delroth closed this issue

2024-05-11 13:24:08 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#300

No description provided.

nix-prefetch-url regresses with commit 121edecf (no decompression) #300

Describe the bug

Steps To Reproduce

Expected behavior

nix --version output

Additional context

nix-prefetch-url regresses with commit `121edecf` (no decompression) #300

`nix --version` output