lix-project/lix

Fork

You've already forked lix

Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Review the commit history looking for release-note-able things that we missed #294

New issue

Closed

opened 2024-05-09 23:25:45 +00:00 by jade · 3 comments

jade commented

2024-05-09 23:25:45 +00:00

Owner

Copy link

Example: https://gerrit.lix.systems/c/lix/+/1062 should probably be release-note'd, since it is an improvement over 2.18 and is nice.

But there's gonna be more of them. I just would have to go write the right git log query to filter out commits with release-notes changes, and then go write some release notes so we can credit the people who have done excellent work on Lix :D

Example: https://gerrit.lix.systems/c/lix/+/1062 should probably be release-note'd, since it is an improvement over 2.18 and is *nice*. But there's gonna be more of them. I just would have to go write the right git log query to filter out commits with release-notes changes, and then go write some release notes so we can [credit the people who have done excellent work on Lix](https://git.lix.systems/lix-project/lix/issues/293) :D

jade added the

release-blocker

label 2024-05-09 23:25:45 +00:00

jade self-assigned this 2024-05-09 23:25:45 +00:00

jade added this to the Release engineering project 2024-05-09 23:25:45 +00:00

pennae commented

2024-05-20 13:09:55 +00:00

Owner

Copy link

went through 2.18.2..origin/main and found a few that may be worth noting:

aeb803de9a feat: add always-allow-substitutes
cba87025f8 Allow user input in git commit
64a269ef73 fix: nix copy ssh-ng:// not respecting --substitute-on-destination
aac8416eac saner default for log-lines: change to 25
fad1a25e17 Add --unpack to nix store prefetch-file
2bb0a06346 Convert Machine::speedFactor from a non-neg int to a non-neg float
41b7876b32 nix: Fix haveInternet to check for proxy
e9b5929b22 Increase stack size on macOS as well as Linux
706f0df55b Include phase reporting in log file for ssh-ng builds
f2c32738ad Print derivation paths
9eb58f5209 structured attrs: improve support / usage of NIX_ATTRS_{SH,JSON}_FILE
6ef9d8efba Print derivation paths in nix eval
1958152d14 Pretty-print values in the REPL
992d99592f :quit in the debugger should quit the whole program
0d85875c3a Allow dlopen of plugins to fail
8044540c42 feat: unprivileged read-only open of SQLite DB
4494f9097f feat: notation to refer to no attribute search prefix
c1319831fb Fix exportReferencesGraph when given store subpath
c03de0df62 gc: Find roots using libproc on Darwin
104448e75d ssh-ng: Set log-fd for ssh to 4 by default
9229e87347 Fix progress bar on copyPaths
0c831765bd Run all derivation builders inside the sandbox on macOS
2e8f9ac944 Warn on untrusted client settings being ignored

https://gerrit.lix.systems/c/lix/+/1175
https://gerrit.lix.systems/c/lix/+/1176 by jade

went through `2.18.2..origin/main` and found a few that may be worth noting: - [x] aeb803de9ad3cd449f7dc85588430ed5b21503eb feat: add always-allow-substitutes - [ ] cba87025f8c0e831a9195ad43d038ce72a69225f Allow user input in `git commit` - [x] 64a269ef73b111d49037812bd899b5cb883158ef fix: nix copy ssh-ng:// not respecting --substitute-on-destination - [x] aac8416eac606c1b6253ae78b8b3168c718366bd saner default for log-lines: change to 25 - [x] fad1a25e17350e67fc9857ba6ec80ac829efd2ed Add --unpack to nix store prefetch-file - [ ] 2bb0a063466e7ef940b91d6eb441d4a0c5f0fb1f Convert `Machine::speedFactor` from a non-neg int to a non-neg float - [ ] 41b7876b32353f7649bccc5c7a11c02bf2e4c67a `nix`: Fix `haveInternet` to check for proxy - [x] e9b5929b22116cb714adfe88ba39a817e89b019c Increase stack size on macOS as well as Linux - [x] 706f0df55b4aaf7d0441227338bd4bec7121fe67 Include phase reporting in log file for ssh-ng builds - [ ] f2c32738ad0862bc6b1cf8d87fa7855ccf763ced Print derivation paths - [ ] 9eb58f5209f9cd1fd18f33b691c6a613075dffc4 structured attrs: improve support / usage of NIX_ATTRS_{SH,JSON}_FILE - [x] 6ef9d8efbadd6eee4a9ebf8ae0835c03989b6c3c Print derivation paths in `nix eval` - [x] 1958152d146389b00c50a149c33012a16864ef83 Pretty-print values in the REPL - [ ] 992d99592f1022593e4df276e39e8f4f65822f74 `:quit` in the debugger should quit the whole program - [ ] 0d85875c3a4284dabad79069758a9056898c42dc Allow dlopen of plugins to fail - [ ] 8044540c426b0dbe4919a74ea9434663ab5a13b2 feat: unprivileged read-only open of SQLite DB - [ ] 4494f9097f7959b2f7e63decf04a5bd592018836 feat: notation to refer to no attribute search prefix - [ ] c1319831fbf26131c0a973b705b9bba7f067a601 Fix exportReferencesGraph when given store subpath - [x] c03de0df627864fb7e83e9af88201b8a5fcd4930 gc: Find roots using libproc on Darwin - [ ] 104448e75d87d03d2fb0b4ac96d4da72e1dae50d ssh-ng: Set log-fd for ssh to `4` by default - [ ] 9229e87347271f41f84f87e80d47d9161231cdc1 Fix progress bar on copyPaths - [ ] 0c831765bd14ebfa41a263ac8da5a3b402510c0b Run all derivation builders inside the sandbox on macOS - [x] 2e8f9ac9446110a3e225ae8384055d83f29fff12 Warn on untrusted client settings being ignored https://gerrit.lix.systems/c/lix/+/1175 https://gerrit.lix.systems/c/lix/+/1176 by jade

❤️ 1

pennae commented

2024-06-01 17:39:06 +00:00

Owner

Copy link

our list still isn't completely release-noted, but we're reasonably sure that all visible/ux-relevant improvements that have a larger impact have notes. should this be considered done for now? (in the future we should definitely be more thorough to ask for release notes on CLs, most of the ones missing here were for backports or minor changes).

@raito @jade close as completed?

raito commented

2024-06-01 17:51:31 +00:00

Owner

Copy link

For me, it's completed. Feel free to reopen if this is a mistake.

raito closed this issue

2024-06-01 17:51:32 +00:00

No Branch/Tag specified

Branches Tags

main

release-2.91

sb/raito/phantom-referrers-gc

repl-overlay-example

reuse-compliance

release-2.90

git-series/activity-cleanup

sb/tom-hubrecht/primops.cc-v2

sb/bacchanalia/cache-strlen%topic=substr-perf

sb/arcuru/commit-msg

sb/qyriad/beta-1

sb/qyriad/2.90-beta.0

rbt/pre-commit-update

sb/rbt/test-branch

sb/rbt/justfile

sb/rbt/repl-overlays

sb/fuck/what

sb/rbt/pre-commit

sb/rbt/makeflags

sb/pennae/io-rewrite

sb/qyriad/maint-meson

sb/qyriad/maint/meson

sb/puck/meson-c-api

sb/pennae/parser-rewrite

sb/jade/burn-it-all

dependabot/github_actions/zeebe-io/backport-action-2.4.1

dependabot/github_actions/cachix/install-nix-action-25

dependabot/github_actions/actions/labeler-5

dependabot/github_actions/cachix/cachix-action-14

2.91.1

2.91.0

2.90.0

2.90.0-rc1

2.90-beta.1

2.90-beta.0

Labels

Clear labels

Area/build-packaging

regarding the building or packaging of Lix itself

Area/cli

The command line interface of Lix

Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

Area/flakes

Area/language

language design, features, extensions, etc

Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

Area/protocol

The protocol, used for communicating between the client and the daemon

libstore and anything else relating to the Nix store

bug

it's a bug

crash 💥

Lix crashes (possibly bad error handling)

Cross Compilation

devx

development experience issues

docs

requires or is about documentation changes

Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

E/easy

bug is relatively simple and could simply be fixed with some minor effort

E/hard

this issue should probably be solved with close involvement of an expert

E/help wanted

maintainers may not get to this soon, but we want it fixed

E/reproducible

This bug is reproducible and obvious.

E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

Needs Langver

We can't get to this until we implement language versioning

OS/Linux

Affects specifically Lix on Linux

OS/macOS

Affects specifically Lix on macOS

performance

make lix go faster

regression

This is a regression since some previous version of Lix

release-blocker

Blocks public release

RFD

Request for discussion

stability

Fixing this makes the software more stable

not our bug, duplicate, similar

Status

postponed

closed but should maybe look at later (generally with S-wontfix)

Status

wontfix

We chose not to change this (see issue comments for more detail).

testing

Tests that should be added

testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

makes the user experience better :)

No labels

Downstream Dependents

E/requires rearchitecture

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Release engineering

Assignees

Clear assignees

No assignees

jade

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#294

Reference in a new issue

Repository

lix-project/lix

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?