riir runCommand2 and remove `environ` crimes #284

New issue

Open

opened 2024-05-08 23:05:29 +00:00 by jade · 0 comments

jade commented

2024-05-08 23:05:29 +00:00

Owner

we have extremely suspect uses of extern char **environ, with weak symbols, evil repetition and more. these may cause some build breakage on freebsd if -Wl,-z,defs is present. also runCommand2 is just generally not very good API. Fixing that API is probably a reasonable second step, but can be done as a first step if in fact required.

rust tends to have reasonable implementations of wrapping the truly horrible Unix APIs, and we can use CommandExt for pretty much everything it does.

Action items:

Figure out how to get rust-analyzer and meson to like each other
Add a rust file that exports a replacement for runCommand2 that takes a struct which is bindgen'd back into c++ land, as well as a replacement for getEnvs
Write runCommand2 in terms of this new more-declarative primitive.

Commit suggestions:

Can even just link a nop into the C++ as the first commit, that gets all the stuff setup
Maybe put bindgen in there, maybe in a second commit
Last commit implements it

we have extremely suspect uses of `extern char **environ`, with weak symbols, evil repetition and more. these may cause some build breakage on freebsd if `-Wl,-z,defs` is present. also runCommand2 is just generally not very good API. Fixing that API is probably a reasonable second step, but can be done as a first step if in fact required. rust tends to have reasonable implementations of wrapping the truly horrible Unix APIs, and we can use `CommandExt` for pretty much everything it does. Action items: - Figure out how to get rust-analyzer and meson to like each other - Add a rust file that exports a replacement for runCommand2 that takes a struct which is bindgen'd back into c++ land, as well as a replacement for `getEnvs` - Write `runCommand2` in terms of this new more-declarative primitive. Commit suggestions: - Can even just link a nop into the C++ as the first commit, that gets all the stuff setup - Maybe put bindgen in there, maybe in a second commit - Last commit implements it

👍 1