Auto setup gerrit commit-msg hook with `nix develop`

jade commented

2024-05-06 06:54:03 +00:00

Owner

Setting up the gerrit commit-msg hook seems kind of annoying and a barrier for new contributors. Maybe we could automate it with in-repo tooling offering to set it up for you in shellHook?

Setting up the gerrit `commit-msg` hook seems kind of annoying and a barrier for new contributors. Maybe we could automate it with in-repo tooling offering to set it up for you in shellHook?

jade added the

devx

E/help wanted

labels 2024-05-06 06:54:03 +00:00

lix-project referenced this issue from a commit

2024-05-07 18:59:04 +00:00

feat: setup gerrit commit-msg hook with nix develop

arcuru commented

2024-05-07 19:11:55 +00:00

I put together a tiny patch that will download it if it isn't present.

I'm new to using Gerrit but I think that's all that's needed? I built this patchset with the change and seemed to go fine.

I put together a tiny patch that will download it if it isn't present. I'm new to using Gerrit but I think that's all that's needed? I built this patchset with the change and seemed to go fine.

qyriad commented

2024-05-07 20:46:53 +00:00

Owner

Huh, the "closes" tag in 268a411ed1 didn't close this issue. Might be a weird permissions thing? Anyway thank you @arcuru!

Huh, the "closes" tag in 268a411ed1e9dfd13dba4b752fcd6e3d095fb7d8 didn't close this issue. Might be a weird permissions thing? Anyway thank you @arcuru!

qyriad closed this issue

2024-05-07 20:46:55 +00:00

jade commented

2024-05-07 20:54:22 +00:00

Author

Owner

fyi this is broken if first run from a worktree. i know how to fix it though, will send a patch. thanks so much for writing this!

👍 1

jade commented

2024-05-07 21:09:50 +00:00

Author

Owner

~~ah, no, it looks like you did the gerrit thing wrong and no change was created. you want to push like git push origin HEAD:refs/for/main rather than git push origin refs/sb/you/somebranch. ~~ wait no https://gerrit.lix.systems/c/lix/+/1054 exists, what. I'll pick up the change, fixup the bug I found, and push it with the workaround %base=refs/heads/main.

~~ah, no, it looks like you did the gerrit thing wrong and no change was created. you want to push like `git push origin HEAD:refs/for/main` rather than `git push origin refs/sb/you/somebranch`. ~~ wait no https://gerrit.lix.systems/c/lix/+/1054 exists, what. I'll pick up the change, fixup the bug I found, and push it with the workaround `%base=refs/heads/main`.

🎉 1

arcuru commented

2024-05-07 21:23:58 +00:00

I pushed it to refs/sb/arcuru/commit-msg first as I was having some issues with Gerrit authentication. That may have messed up some references.

I pushed it to `refs/sb/arcuru/commit-msg` first as I was having some issues with Gerrit authentication. That may have messed up some references.

jade commented

2024-05-07 21:26:41 +00:00

Author

Owner

oh, i see. Yeah that caused it to get replicated to forgejo which lightly confused qyriad since it would not close the issue unless it was on main. This workflow is fine, it just has some annoyance if you later want to push the changes for review as gerrit gets confused that it's already on a branch and you have to pass %base= to make it happy (https://gerrit-review.googlesource.com/Documentation/user-upload.html#base).

oh, i see. Yeah that caused it to get replicated to forgejo which lightly confused qyriad since it would not close the issue unless it was on `main`. This workflow is fine, it just has some annoyance if you later want to push the changes for review as gerrit gets confused that it's already on a branch and you have to pass `%base=` to make it happy (https://gerrit-review.googlesource.com/Documentation/user-upload.html#base).

qyriad commented

2024-05-07 21:40:28 +00:00

Owner

Oops, so this should probably stay open in https://gerrit.lix.systems/c/lix/+/1054/ is actually merged, sorry 😅

qyriad reopened this issue

2024-05-07 21:40:28 +00:00

lix-project referenced this issue from a commit

2024-05-07 22:52:18 +00:00

feat: setup gerrit commit-msg hook with nix develop

lix-project closed this issue

2024-05-07 22:52:18 +00:00

Auto setup gerrit commit-msg hook with nix develop #273

Auto setup gerrit commit-msg hook with `nix develop` #273