Things failing for being untrusted user don't log anything and instead silently no-op #261

New issue

Open

opened 2024-05-04 03:02:23 +00:00 by jade · 1 comment

jade commented

2024-05-04 03:02:23 +00:00

Owner

This is the case for at least a few things including possibly nix copy --no-check-sigs, where the thing just fails silently because of being untrusted instead of producing either an error or a warning.

This is the case for at least a few things including possibly `nix copy --no-check-sigs`, where the thing just fails silently because of being untrusted instead of producing either an error or a warning.

jade added the

label 2024-05-04 03:02:23 +00:00

jade commented

2024-05-05 04:31:54 +00:00

Author

Owner

It sure seems that ClientSettings::apply is simply printing these messages to debug. So let's change that. https://gerrit.lix.systems/c/lix/+/1026

This isn't a complete fix to all instances of this problem, we also have the usual signature refusal due to being untrusted on a remote builder. That one also needs to warn.

Steps to help:

Set up a remote builder without trusted user access on the remote machine
Find the warning (if any) with --debug, or go grepping for trusted user stuff in the codebase
Add warn() calls when these permission checks fail.

It sure seems that `ClientSettings::apply` is simply printing these messages to `debug`. So let's change that. https://gerrit.lix.systems/c/lix/+/1026 This isn't a complete fix to all instances of this problem, we also have the usual signature refusal due to being untrusted on a remote builder. That one also needs to warn. Steps to help: - Set up a remote builder without trusted user access on the remote machine - Find the warning (if any) with `--debug`, or go grepping for trusted user stuff in the codebase - Add `warn()` calls when these permission checks fail.

jade added the

E/help wanted

E/easy

labels 2024-05-05 04:32:18 +00:00