`builtins.getFlake` accepts `git+file:/home/...` AND `git+file:///home/...` with different semantics #200

New issue

Open

opened 2024-03-29 22:27:14 +00:00 by rbt · 2 comments

rbt commented

2024-03-29 22:27:14 +00:00

Owner

git+file: gets the latest commit and git+file:// gets the changes in the working tree. What the hell.

nix-repl> (builtins.getFlake "git+file:/Users/wiggles/infrastructure").outPath
"/nix/store/7j7smga3nxq1sn392c863cja4vv5m12l-source"

nix-repl> (builtins.getFlake "git+file:///Users/wiggles/infrastructure").outPath
"/nix/store/hry7m94vcmy3jznf6qyg8k0f4jhyw2dx-source"

`git+file:` gets the latest commit and `git+file://` gets the changes in the working tree. What the hell. ``` nix-repl> (builtins.getFlake "git+file:/Users/wiggles/infrastructure").outPath "/nix/store/7j7smga3nxq1sn392c863cja4vv5m12l-source" nix-repl> (builtins.getFlake "git+file:///Users/wiggles/infrastructure").outPath "/nix/store/hry7m94vcmy3jznf6qyg8k0f4jhyw2dx-source" ```

rbt added the

bug

label 2024-03-29 22:27:14 +00:00

lunaphied commented

2024-03-29 22:31:13 +00:00

Owner

Please test this on upstream unstable and report if the same behavior happens; I noticed these seemed to possibly change behavior on later versions and want to decide an approach to take.

Also note that in certain contexts git+file:. and "git+file://" + (toString ./.) also work, so it'd be interesting to see how they compare

Please test this on upstream unstable and report if the same behavior happens; I noticed these seemed to possibly change behavior on later versions and want to decide an approach to take. Also note that in certain contexts `git+file:.` and `"git+file://" + (toString ./.)` also work, so it'd be interesting to see how they compare