lix-project/lix
19
51
Fork 27
Code Issues 339 Code Review (Gerrit) Projects 1 Releases Wiki Activity

Handle SSH connection drops with remote builders more gracefully #185

New issue
Open
opened 2024-03-25 18:37:10 +00:00 by mweinelt · 0 comments
mweinelt commented 2024-03-25 18:37:10 +00:00
Member
Copy link

Describe the bug

A remote build suddenly errored out with

error: builder for '/nix/store/58jxr2x94kz4zq5x5gqffjsyz7kpxhgc-cargo-c-0.9.29.drv' failed with exit code 1
error: Nix daemon disconnected unexpectedly (maybe it crashed?)

On the remote builder (nix 2.18.2) I can find

Mar 25 18:20:04 build2 nix-daemon[1917]: accepted connection from pid 880823, user hexa (trusted)
Mar 25 18:21:43 build2 nix-daemon[880825]: terminate called after throwing an instance of 'nix::Interrupted'
Mar 25 18:21:43 build2 nix-daemon[880825]:   what():  error: interrupted by the user

A coredump was created due to SIGABRT

Call trace 
#0  0x00007fb74c3e107c in __pthread_kill_implementation () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6
No symbol table info available.
#1  0x00007fb74c391e06 in raise () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6
No symbol table info available.
#2  0x00007fb74c37a8f5 in abort () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6
No symbol table info available.
#3  0x00007fb74c6f2c0b in __gnu_cxx::__verbose_terminate_handler() [clone .cold] () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6
No symbol table info available.
#4  0x00007fb74c70221a in __cxxabiv1::__terminate(void (*)()) () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6
No symbol table info available.
#5  0x00007fb74c701299 in __cxa_call_terminate () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6
No symbol table info available.
#6  0x00007fb74c7019a6 in __gxx_personality_v0 () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6
No symbol table info available.
#7  0x00007fb74c5579f9 in _Unwind_RaiseException_Phase2 () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libgcc_s.so.1
No symbol table info available.
#8  0x00007fb74c5584ed in _Unwind_Resume () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libgcc_s.so.1
No symbol table info available.
#9  0x00007fb74cac3d66 in nix::curlFileTransfer::enqueueFileTransfer(nix::FileTransferRequest const&, nix::Callback) [clone .cold] ()
   from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#10 0x00007fb74cbae21d in nix::HttpBinaryCacheStore::getFile(std::__cxx11::basic_string, std::allocator > const&, nix::Callback, std::allocator > > >) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#11 0x00007fb74caf990c in nix::BinaryCacheStore::queryPathInfoUncached(nix::StorePath const&, nix::Callback >) ()
   from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#12 0x00007fb74cc13a5a in nix::Store::queryPathInfo(nix::StorePath const&, nix::Callback >) ()
   from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#13 0x00007fb74cc13eed in nix::Store::queryPathInfo(nix::StorePath const&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#14 0x00007fb74cc14580 in nix::Store::querySubstitutablePathInfos(std::map, std::less, std::allocator > > > const&, std::map, std::allocator > >&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#15 0x00007fb74cbcbca0 in nix::Store::queryMissing(std::vector > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&)::{lambda(nix::StorePath const&, nix::ref, nix::StorePath const&, nix::ref > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >)#1}::operator()(nix::StorePath const&, nix::ref, nix::StorePath const&, nix::ref > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >) const [clone .lto_priv.0] ()
   from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#16 0x00007fb74cbd4322 in std::_Function_handler > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&)::{lambda(nix::StorePath const&, nix::ref, nix::StorePath const&, nix::ref > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned --Type  for more, q to quit, c to continue without paging--
long&)::DrvState, std::mutex> >)#1} (nix::StorePath, nix::ref, nix::StorePath, nix::ref > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >)> >::_M_invoke(std::_Any_data const&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#17 0x00007fb74c9db1e1 in nix::ThreadPool::doWork(bool) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixutil.so
No symbol table info available.
#18 0x00007fb74c9db503 in nix::ThreadPool::process() () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixutil.so
No symbol table info available.
#19 0x00007fb74cbd2ed8 in nix::Store::queryMissing(std::vector > const&, std::set, std::allocator >&, std::set, std::allocator >&, std::set, std::allocator >&, unsigned long&, unsigned long&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so
No symbol table info available.
#20 0x000056028a40e9dd in main_nix_build(int, char**)::{lambda(std::vector > const&)#1}::operator()(std::vector > const&) const [clone .lto_priv.0] ()
No symbol table info available.
#21 0x000056028a4157c5 in main_nix_build(int, char**) [clone .lto_priv.0] ()
No symbol table info available.
#22 0x000056028a4a009e in nix::mainWrapped(int, char**) ()
No symbol table info available.
#23 0x00007fb74cdaa5f7 in nix::handleExceptions(std::__cxx11::basic_string, std::allocator > const&, std::function) ()
   from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixmain.so
No symbol table info available.
#24 0x000056028a3fe61c in main ()
No symbol table info available.

Steps To Reproduce

  1. Use the remote building functionality
  2. ???

Expected behavior

The assumption is that the SSH connection died. The error messsage could have been clearer.

The error was supposed to be transient. The connection could've been retried.

nix-env --version output

nix-env (Nix) 2.90.0-lix

Additional context

n/a

## Describe the bug A remote build suddenly errored out with ``` error: builder for '/nix/store/58jxr2x94kz4zq5x5gqffjsyz7kpxhgc-cargo-c-0.9.29.drv' failed with exit code 1 error: Nix daemon disconnected unexpectedly (maybe it crashed?) ``` On the remote builder (nix 2.18.2) I can find ``` Mar 25 18:20:04 build2 nix-daemon[1917]: accepted connection from pid 880823, user hexa (trusted) Mar 25 18:21:43 build2 nix-daemon[880825]: terminate called after throwing an instance of 'nix::Interrupted' Mar 25 18:21:43 build2 nix-daemon[880825]: what(): error: interrupted by the user ``` A coredump was created due to SIGABRT <details><summary>Call trace</summary> <pre> #0 0x00007fb74c3e107c in __pthread_kill_implementation () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6 No symbol table info available. #1 0x00007fb74c391e06 in raise () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6 No symbol table info available. #2 0x00007fb74c37a8f5 in abort () from /nix/store/ksk3rnb0ljx8gngzk19jlmbjyvac4hw6-glibc-2.38-44/lib/libc.so.6 No symbol table info available. #3 0x00007fb74c6f2c0b in __gnu_cxx::__verbose_terminate_handler() [clone .cold] () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6 No symbol table info available. #4 0x00007fb74c70221a in __cxxabiv1::__terminate(void (*)()) () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6 No symbol table info available. #5 0x00007fb74c701299 in __cxa_call_terminate () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6 No symbol table info available. #6 0x00007fb74c7019a6 in __gxx_personality_v0 () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libstdc++.so.6 No symbol table info available. #7 0x00007fb74c5579f9 in _Unwind_RaiseException_Phase2 () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libgcc_s.so.1 No symbol table info available. #8 0x00007fb74c5584ed in _Unwind_Resume () from /nix/store/pp0jsd045xvfsz60kpbkfxbs9pbpk8z5-gcc-13.2.0-lib/lib/libgcc_s.so.1 No symbol table info available. #9 0x00007fb74cac3d66 in nix::curlFileTransfer::enqueueFileTransfer(nix::FileTransferRequest const&, nix::Callback<nix::FileTransferResult>) [clone .cold] () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #10 0x00007fb74cbae21d in nix::HttpBinaryCacheStore::getFile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, nix::Callback<std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #11 0x00007fb74caf990c in nix::BinaryCacheStore::queryPathInfoUncached(nix::StorePath const&, nix::Callback<std::shared_ptr<nix::ValidPathInfo const> >) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #12 0x00007fb74cc13a5a in nix::Store::queryPathInfo(nix::StorePath const&, nix::Callback<nix::ref<nix::ValidPathInfo const> >) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #13 0x00007fb74cc13eed in nix::Store::queryPathInfo(nix::StorePath const&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #14 0x00007fb74cc14580 in nix::Store::querySubstitutablePathInfos(std::map<nix::StorePath, std::optional<nix::ContentAddress>, std::less<nix::StorePath>, std::allocator<std::pair<nix::StorePath const, std::optional<nix::ContentAddress> > > > const&, std::map<nix::StorePath, nix::SubstitutablePathInfo, std::less<nix::StorePath>, std::allocator<std::pair<nix::StorePath const, nix::SubstitutablePathInfo> > >&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #15 0x00007fb74cbcbca0 in nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&)::{lambda(nix::StorePath const&, nix::ref<nix::Derivation>, nix::StorePath const&, nix::ref<nix::Sync<nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >)#1}::operator()(nix::StorePath const&, nix::ref<nix::Derivation>, nix::StorePath const&, nix::ref<nix::Sync<nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >) const [clone .lto_priv.0] () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #16 0x00007fb74cbd4322 in std::_Function_handler<void (), std::_Bind<nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&)::{lambda(nix::StorePath const&, nix::ref<nix::Derivation>, nix::StorePath const&, nix::ref<nix::Sync<nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned --Type <RET> for more, q to quit, c to continue without paging-- long&)::DrvState, std::mutex> >)#1} (nix::StorePath, nix::ref<nix::Derivation>, nix::StorePath, nix::ref<nix::Sync<nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&)::DrvState, std::mutex> >)> >::_M_invoke(std::_Any_data const&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #17 0x00007fb74c9db1e1 in nix::ThreadPool::doWork(bool) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixutil.so No symbol table info available. #18 0x00007fb74c9db503 in nix::ThreadPool::process() () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixutil.so No symbol table info available. #19 0x00007fb74cbd2ed8 in nix::Store::queryMissing(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, std::set<nix::StorePath, std::less<nix::StorePath>, std::allocator<nix::StorePath> >&, unsigned long&, unsigned long&) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixstore.so No symbol table info available. #20 0x000056028a40e9dd in main_nix_build(int, char**)::{lambda(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&)#1}::operator()(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath> > const&) const [clone .lto_priv.0] () No symbol table info available. #21 0x000056028a4157c5 in main_nix_build(int, char**) [clone .lto_priv.0] () No symbol table info available. #22 0x000056028a4a009e in nix::mainWrapped(int, char**) () No symbol table info available. #23 0x00007fb74cdaa5f7 in nix::handleExceptions(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::function<void ()>) () from /nix/store/cs41wvvf98zsgw7vbpfabj5f8d2y0ihz-nix-2.18.2/lib/libnixmain.so No symbol table info available. #24 0x000056028a3fe61c in main () No symbol table info available. </pre> </details> ## Steps To Reproduce 1. Use the remote building functionality 2. ??? ## Expected behavior The assumption is that the SSH connection died. The error messsage could have been clearer. The error was supposed to be transient. The connection could've been retried. ## `nix-env --version` output nix-env (Nix) 2.90.0-lix ## Additional context n/a
mweinelt added the
bug
 label 2024-03-25 18:37:10 +00:00
jade added the
Area/remote-builds
 label 2024-05-23 00:51:02 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
build-remote-ipc
sb/raito/phantom-referrers-gc
repl-overlay-example
release-2.91
reuse-compliance
release-2.90
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/cli

The command line interface of Lix

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/flakes

   
Area/language

language design, features, extensions, etc

  
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol

The protocol, used for communicating between the client and the daemon

  
Area/releng

Release engineering

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
Cross Compilation

   
devx

development experience issues

  
docs

requires or is about documentation changes

  
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#185
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?