`No such file or directory` in flakes is a terrible error message

jade commented

2024-03-25 05:02:59 +00:00

Owner

Steps to reproduce:

Create somefile.nix and forget to add it to git.
import ./somefile.nix in flake.nix
Get a confusing error message.

At the very least, for now we should consider catching that particular error and printing a hint that it might be that, for flakes, even without checking the original directory for if the file is there.

This error can be more properly diagnosed after pennae finishes the future big evaluator IO refactor.

Steps to reproduce: 1. Create somefile.nix and forget to add it to git. 2. `import ./somefile.nix` in flake.nix 3. Get a confusing error message. At the very least, *for now* we should consider catching that particular error and printing a hint that it might be that, for flakes, even without checking the original directory for if the file is there. This error can be more properly diagnosed after pennae finishes the future big evaluator IO refactor. See also @qyriad 's PR: https://github.com/NixOS/nix/pull/9398

jade added the

ux

E/easy

E/help wanted

labels 2024-03-25 05:03:00 +00:00

qyriad commented

2024-03-25 06:31:35 +00:00

Owner

We have a branch somewhere that adds the filepaths involved in IO errors to the relevant exception classes and uses it in the error message.

@rbt 's structured errors PR would probably be a better foundation though

We have a branch somewhere that adds the filepaths involved in IO errors to the relevant exception classes and uses it in the error message. @rbt 's structured errors PR would probably be a better foundation though

qyriad commented

2024-03-25 16:37:22 +00:00

Owner

Found our branch: https://github.com/Qyriad/nix/compare/19993398a12069a868b0fb10b63f7d06f0f993e6...Qyriad:nix:cdc1a66e31c499506f6de4c7d8718ff09b105655

Found our branch: [https://github.com/Qyriad/nix/compare/19993398a12069a868b0fb10b63f7d06f0f993e6...Qyriad:nix:cdc1a66e31c499506f6de4c7d8718ff09b105655](https://github.com/Qyriad/nix/compare/19993398a12069a868b0fb10b63f7d06f0f993e6...Qyriad:nix:cdc1a66e31c499506f6de4c7d8718ff09b105655)

gabriella439 commented

2024-03-25 16:42:33 +00:00

Member

Is there any reason we don't want to check the original directory to see if the file was there?

qyriad commented

2024-03-25 16:45:01 +00:00

Owner

Our branch does this: cdc1a66e31/src/libexpr/flake/flake.cc (L224)

Our branch does this: https://github.com/Qyriad/nix/blob/cdc1a66e31c499506f6de4c7d8718ff09b105655/src/libexpr/flake/flake.cc#L224

🎉 1

jade commented

2024-03-25 16:45:35 +00:00

Author

Owner

Is there any reason we don't want to check the original directory to see if the file was there?

Mainly for potential lack of having the information. If we have the information, absolutely do it though.

> Is there any reason we don't want to check the original directory to see if the file was there? Mainly for potential lack of *having* the information. If we have the information, absolutely do it though.

👍 1

yu-re-ka commented

2024-03-28 00:03:18 +00:00

Member

When the original source dir is available, this could even go one step further and throw a warning when builtins.readDir is called, but not all directory entries are present in the store, for example forgetting to add a pkgs/by-name.

jade added the

Area/flakes

label 2024-03-30 00:04:22 +00:00

jade was assigned by qyriad

2024-05-13 00:36:54 +00:00