Lock paths can become too long when remote builders are involved

lunaphied commented

2024-03-19 02:11:27 +00:00

Owner

Running installChecks on dea029ff51 causes an error due to using the ridiculously long lockfile path of:

/build/nix-shell.CAf3tZ/nix-test/build-remote-trustless-should-pass-3/local/nix/var/nix/current-load/ssh-ng:__localhost?remote-program=_home_lunaphied_code_lix_.w_maint_backport_flake-lock-ux_tests_functional_nix-daemon-untrusting.sh&remote-store=_build_nix-shell.CAf3tZ_nix-test_build-remote-trustless-should-pass-3_remote%3Fsystem-features=foo%20bar%20baz-0

This should likely be replaced by a hash instead so that the name cannot become absurdly long.

Running `installChecks` on https://gerrit.lix.systems/plugins/gitiles/lix/+/dea029ff5141870bed84d4b578f3683280654d7d causes an error due to using the ridiculously long lockfile path of: ``` /build/nix-shell.CAf3tZ/nix-test/build-remote-trustless-should-pass-3/local/nix/var/nix/current-load/ssh-ng:__localhost?remote-program=_home_lunaphied_code_lix_.w_maint_backport_flake-lock-ux_tests_functional_nix-daemon-untrusting.sh&remote-store=_build_nix-shell.CAf3tZ_nix-test_build-remote-trustless-should-pass-3_remote%3Fsystem-features=foo%20bar%20baz-0 ``` This should likely be replaced by a hash instead so that the name cannot become absurdly long.

installCheck.log

15 KiB

lunaphied added the

bug

label 2024-03-19 02:11:27 +00:00

lunaphied referenced this issue

2024-04-03 22:55:12 +00:00

build-remote-trustless tests fail if PWD is too long #221

qyriad referenced this issue

2024-04-03 22:58:18 +00:00

build-remote-trustless tests fail if PWD is too long #221

qyriad commented

2024-04-03 23:00:56 +00:00

Owner

Why does the entire remote builder configuration get encoded into a lockfile path in the first place??

lunaphied commented

2024-04-04 01:21:14 +00:00

Author

Owner

See https://git.lix.systems/lix-project/lix/src/branch/main/src/build-remote/build-remote.cc#L40 and https://git.lix.systems/lix-project/lix/src/branch/main/src/build-remote/build-remote.cc#L266

jade commented

2024-04-04 04:09:08 +00:00

Owner

O_o

simply sha256 the normalized url and take some prefix or so

O_o simply sha256 the normalized url and take some prefix or so

lunaphied commented

2024-04-08 23:04:41 +00:00

Author

Owner

From Nixpkgs' definition of the Nix package:

  # socket path becomes too long otherwise
  preInstallCheck = lib.optionalString stdenv.isDarwin ''
    export TMPDIR=$NIX_BUILD_TOP
  ''

Wonder if this is relevant.

From Nixpkgs' definition of the Nix package: ```nix # socket path becomes too long otherwise preInstallCheck = lib.optionalString stdenv.isDarwin '' export TMPDIR=$NIX_BUILD_TOP '' ``` Wonder if this is relevant.

jade commented

2024-04-08 23:40:51 +00:00

Owner

honestly we should just fix this in a generalized manner by hashing the path though (maybe minus one component? maybe print out the full name so you can find which process was doing it? just to not regress the ability to find who is holding a lock)

lunaphied was assigned by qyriad

2024-05-12 19:22:44 +00:00