lix-project/lix
20
58
Fork 31
Code Issues 354 Code Review (Gerrit) Projects 3 Releases Wiki Activity

[Nix#3701] fetchGit can't handle annotated tags #152

New issue
Open
opened 2024-03-19 01:01:31 +00:00 by lix-bot · 2 comments
lix-bot commented 2024-03-19 01:01:31 +00:00
Member
Copy link

Upstream-Issue: NixOS/nix#3701

Description

Currently builtins.fetchGit does not seem to handle annotated tags and fails with:

error: cannot update ref 'refs/heads/xyz': trying to write non-commit object 098abc123 to branch 'refs/heads/xyz'

Reproduction

You can see me reproduce this in https://github.com/status-im/status-react/issues/10825.

Docs

This was reported once in #2385 and a fix for docs was applied in ae244af242 by adding:

Due to a bug #2385 only non-annotated tags can be fetched.

To documentation of builtins.fetchGit, but that change does not seem to be there in current docs:
https://nixos.org/nix/manual/#ssec-builtins
And there doesn't appear to be any fix in sight.

Solutions

If the fix is difficult to implement for builtins.fetchGit could we at least update the documentation with this information and make fetchGit return an error that actually makes sense instead of this trying to write non-commit object nonsense?

Upstream-Issue: https://git.lix.systems/NixOS/nix/issues/3701 ## Description Currently `builtins.fetchGit` does not seem to handle annotated tags and fails with: ``` error: cannot update ref 'refs/heads/xyz': trying to write non-commit object 098abc123 to branch 'refs/heads/xyz' ``` ## Reproduction You can see me reproduce this in https://github.com/status-im/status-react/issues/10825. ## Docs This was reported once in #2385 and a fix for docs was applied in ae244af242ca3621e5a3b9196f27d9fcbf297266 by adding: >Due to a bug #2385 only non-annotated tags can be fetched. To documentation of `builtins.fetchGit`, but that change does not seem to be there in current docs: https://nixos.org/nix/manual/#ssec-builtins And there doesn't appear to be any fix in sight. ## Solutions If the fix is difficult to implement for `builtins.fetchGit` could we at least update the documentation with this information and make `fetchGit` return an error that actually makes sense instead of this `trying to write non-commit object` nonsense?
lix-bot added the
bug
imported
 labels 2024-03-19 01:01:31 +00:00
qyriad commented 2024-05-12 19:40:53 +00:00
Owner
Copy link

It seems to be more complex than this. On Lix and Nix 2.18 alike, builtins.fetchGit fails to fetch any tag unless it's prefixed with refs/tags/, but if can fetch annotated tags if they are prefixed. In Nix 2.3 however, builtins.fetchGit can fetch unannotated tags unprefixed, but annotated tags need refs/tags/.

Lix:

Lix 2.90.0-lixpre20240511-a30c567

nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; }
fatal: couldn't find remote ref refs/heads/v2.0.3-status
error:
       … while calling the 'fetchGit' builtin
         at «string»:1:1:
            1| builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; }
             | ^

       … while fetching the input 'git+https://github.com/tbenr/react-native-audio-toolkit?ref=v2.0.3-status'

       error: program 'git' failed with exit code 128

nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; }
{
  lastModified = 1592064236;
  lastModifiedDate = "20200613160356";
  narHash = "sha256-VLUvxb9xRpMjkfASt4d4UMjnL0HlLb8ZEQKrk4RFZn4=";
  outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source";
  rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f";
  revCount = 219;
  shortRev = "53e823d";
  submodules = false;
}

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; }
fatal: couldn't find remote ref refs/heads/v0.2.5
error:
       … while calling the 'fetchGit' builtin
         at «string»:1:1:
            1| builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; }
             | ^

       … while fetching the input 'git+https://github.com/Qyriad/log2compdb?ref=v0.2.5'

       error: program 'git' failed with exit code 128

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; }
{
  lastModified = 1693509864;
  lastModifiedDate = "20230831192424";
  narHash = "sha256-+olw0aMxsWbsmYvJEBAw2QCS6zPE7YyV46o2Vhn4VsY=";
  outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source";
  rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756";
  revCount = 38;
  shortRev = "b3a6989";
  submodules = false;
}

nix-repl>

2.18:

Welcome to Nix 2.18.2. Type :? for help.
nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; }
fatal: couldn't find remote ref refs/heads/v2.0.3-status
error:
       … while calling the 'fetchGit' builtin

         at «string»:1:1:

            1| builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; }
             | ^

       … while fetching the input 'git+https://github.com/tbenr/react-native-audio-toolkit?ref=v2.0.3-status'

       error: program 'git' failed with exit code 128

nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; }
{ lastModified = 1592064236; lastModifiedDate = "20200613160356"; narHash = "sha256-VLUvxb9xRpMjkfASt4d4UMjnL0HlLb8ZEQKrk4RFZn4="; outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source"; rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f"; revCount = 219; shortRev = "53e823d"; submodules = false; }

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; }
fatal: couldn't find remote ref refs/heads/v0.2.5
error:
       … while calling the 'fetchGit' builtin

         at «string»:1:1:

            1| builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; }
             | ^

       … while fetching the input 'git+https://github.com/Qyriad/log2compdb?ref=v0.2.5'

       error: program 'git' failed with exit code 128

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; }
{ lastModified = 1693509864; lastModifiedDate = "20230831192424"; narHash = "sha256-+olw0aMxsWbsmYvJEBAw2QCS6zPE7YyV46o2Vhn4VsY="; outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; submodules = false; }

nix-repl>

2.3:

Welcome to Nix version 2.3.18. Type :? for help.

nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; }
fetching Git repository 'https://github.com/tbenr/react-native-audio-toolkit'error: cannot update ref 'refs/heads/v2.0.3-status': trying to write non-commit object 53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f to branch 'refs/heads/v2.0.3-status'
error: program 'git' failed with exit code 1



nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; }
{ outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source"; rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f"; revCount = 219; shortRev = "53e823d"; }

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; }
{ outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; }

nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; }
{ outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; }

nix-repl>
It seems to be more complex than this. On Lix and Nix 2.18 alike, `builtins.fetchGit` fails to fetch *any* tag unless it's prefixed with `refs/tags/`, but if can fetch annotated tags if they are prefixed. In Nix 2.3 however, `builtins.fetchGit` can fetch *un*annotated tags unprefixed, but annotated tags need `refs/tags/`. Lix: ```nix Lix 2.90.0-lixpre20240511-a30c567 nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; } fatal: couldn't find remote ref refs/heads/v2.0.3-status error: … while calling the 'fetchGit' builtin at «string»:1:1: 1| builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; } | ^ … while fetching the input 'git+https://github.com/tbenr/react-native-audio-toolkit?ref=v2.0.3-status' error: program 'git' failed with exit code 128 nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; } { lastModified = 1592064236; lastModifiedDate = "20200613160356"; narHash = "sha256-VLUvxb9xRpMjkfASt4d4UMjnL0HlLb8ZEQKrk4RFZn4="; outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source"; rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f"; revCount = 219; shortRev = "53e823d"; submodules = false; } nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; } fatal: couldn't find remote ref refs/heads/v0.2.5 error: … while calling the 'fetchGit' builtin at «string»:1:1: 1| builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; } | ^ … while fetching the input 'git+https://github.com/Qyriad/log2compdb?ref=v0.2.5' error: program 'git' failed with exit code 128 nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; } { lastModified = 1693509864; lastModifiedDate = "20230831192424"; narHash = "sha256-+olw0aMxsWbsmYvJEBAw2QCS6zPE7YyV46o2Vhn4VsY="; outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; submodules = false; } nix-repl> ``` 2.18: ```nix Welcome to Nix 2.18.2. Type :? for help. nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; } fatal: couldn't find remote ref refs/heads/v2.0.3-status error: … while calling the 'fetchGit' builtin at «string»:1:1: 1| builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; } | ^ … while fetching the input 'git+https://github.com/tbenr/react-native-audio-toolkit?ref=v2.0.3-status' error: program 'git' failed with exit code 128 nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; } { lastModified = 1592064236; lastModifiedDate = "20200613160356"; narHash = "sha256-VLUvxb9xRpMjkfASt4d4UMjnL0HlLb8ZEQKrk4RFZn4="; outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source"; rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f"; revCount = 219; shortRev = "53e823d"; submodules = false; } nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; } fatal: couldn't find remote ref refs/heads/v0.2.5 error: … while calling the 'fetchGit' builtin at «string»:1:1: 1| builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; } | ^ … while fetching the input 'git+https://github.com/Qyriad/log2compdb?ref=v0.2.5' error: program 'git' failed with exit code 128 nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; } { lastModified = 1693509864; lastModifiedDate = "20230831192424"; narHash = "sha256-+olw0aMxsWbsmYvJEBAw2QCS6zPE7YyV46o2Vhn4VsY="; outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; submodules = false; } nix-repl> ``` 2.3: ```nix Welcome to Nix version 2.3.18. Type :? for help. nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "v2.0.3-status"; } fetching Git repository 'https://github.com/tbenr/react-native-audio-toolkit'error: cannot update ref 'refs/heads/v2.0.3-status': trying to write non-commit object 53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f to branch 'refs/heads/v2.0.3-status' error: program 'git' failed with exit code 1 nix-repl> builtins.fetchGit { url = "https://github.com/tbenr/react-native-audio-toolkit"; ref = "refs/tags/v2.0.3-status"; } { outPath = "/nix/store/idsax8hnzcn3pv56x2gmqr5mvy5564xb-source"; rev = "53e823d1bd0dffd7bf799ccfb8fccd3e4023d00f"; revCount = 219; shortRev = "53e823d"; } nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "v0.2.5"; } { outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; } nix-repl> builtins.fetchGit { url = "https://github.com/Qyriad/log2compdb"; ref = "refs/tags/v0.2.5"; } { outPath = "/nix/store/b8kjjfpwx7185wb3bj1x321hjm84h1f2-source"; rev = "b3a69891b7ced1e38a9af2f9e440d37718a92756"; revCount = 38; shortRev = "b3a6989"; } nix-repl> ```
lix-bot commented 2024-07-09 23:07:55 +00:00
Author
Member
Copy link

This issue was mentioned on Gerrit on the following CLs:

  • comment in cl/1353 ("libfetchers/git: restore compat with builtins.fetchGit from 2.3")
<!-- GERRIT_LINKBOT: {"cls": [{"backlink": "https://gerrit.lix.systems/c/lix/+/1353", "number": 1353, "kind": "comment"}], "cl_meta": {"1353": {"change_title": "libfetchers/git: restore compat with `builtins.fetchGit` from 2.3"}}} --> This issue was mentioned on Gerrit on the following CLs: * comment in [cl/1353](https://gerrit.lix.systems/c/lix/+/1353) ("libfetchers/git: restore compat with `builtins.fetchGit` from 2.3")
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.91
sb/raito/phantom-referrers-gc
repl-overlay-example
reuse-compliance
release-2.90
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.91.1
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/cli

The command line interface of Lix

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

  
Area/flakes

   
Area/language

language design, features, extensions, etc

  
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol

The protocol, used for communicating between the client and the daemon

  
Area/releng

Release engineering

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
crash 💥

Lix crashes (possibly bad error handling)

  
Cross Compilation

   
devx

development experience issues

  
docs

requires or is about documentation changes

  
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#152
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?