lix-project/lix
20
57
Fork 31
Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity

[Nix#8508] nix-collect-garbage -d does not clean up user profiles in XDG directories when run as root #151

New issue
Open
opened 2024-03-19 01:01:30 +00:00 by lix-bot · 1 comment
lix-bot commented 2024-03-19 01:01:30 +00:00
Member
Copy link

Upstream-Issue: NixOS/nix#8508

Describe the bug

❯ ls .local/state/nix/profiles 
home-manager@  home-manager-14-link@  home-manager-15-link@  home-manager-16-link@  profile@  profile-12-link@  profile-13-link@  profile-14-link@

❯ sudo nix-collect-garbage -d
removing old generations of profile /nix/var/nix/profiles/per-user/root/profile
removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager
removing profile version 257
removing profile version 258
removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile
removing old generations of profile /nix/var/nix/profiles/system
removing profile version 502
removing profile version 503
removing old generations of profile /nix/var/nix/profiles/default
removing old generations of profile /nix/var/nix/profiles/per-user/root/profile
removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager
finding garbage collector roots...
<snip>

❯ ls .local/state/nix/profiles
home-manager@  home-manager-14-link@  home-manager-15-link@  home-manager-16-link@  profile@  profile-12-link@  profile-13-link@  profile-14-link@

❯ sudo nix-collect-garbage -d --option use-xdg-base-directories true
removing old generations of profile /nix/var/nix/profiles/per-user/root/profile
removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager
removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile
removing old generations of profile /nix/var/nix/profiles/system
removing old generations of profile /nix/var/nix/profiles/default
removing old generations of profile /nix/var/nix/profiles/per-user/root/profile
removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager
finding garbage collector roots...
<snip>

❯ ls .local/state/nix/profiles
home-manager@  home-manager-14-link@  home-manager-15-link@  home-manager-16-link@  profile@  profile-12-link@  profile-13-link@  profile-14-link@

❯ nix-collect-garbage -d     
removing old generations of profile /home/k900/.local/state/nix/profiles/home-manager
removing profile version 14
removing profile version 15
removing old generations of profile /home/k900/.local/state/nix/profiles/profile
removing profile version 12
removing profile version 13
removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile
finding garbage collector roots...
<snip>

Expected behavior

home-manager generations are cleaned up on the first sudo nix-collect-garbage -d invocation.

nix-env --version output

nix-collect-garbage (Nix) 2.16.1

Additional context

I'm not sure when this started happening, but I feel like it might have something to do with HM switching to XDG paths?

Priorities

Add 👍 to issues you find important.

Upstream-Issue: https://git.lix.systems/NixOS/nix/issues/8508 **Describe the bug** ``` ❯ ls .local/state/nix/profiles home-manager@ home-manager-14-link@ home-manager-15-link@ home-manager-16-link@ profile@ profile-12-link@ profile-13-link@ profile-14-link@ ❯ sudo nix-collect-garbage -d removing old generations of profile /nix/var/nix/profiles/per-user/root/profile removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager removing profile version 257 removing profile version 258 removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile removing old generations of profile /nix/var/nix/profiles/system removing profile version 502 removing profile version 503 removing old generations of profile /nix/var/nix/profiles/default removing old generations of profile /nix/var/nix/profiles/per-user/root/profile removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager finding garbage collector roots... <snip> ❯ ls .local/state/nix/profiles home-manager@ home-manager-14-link@ home-manager-15-link@ home-manager-16-link@ profile@ profile-12-link@ profile-13-link@ profile-14-link@ ❯ sudo nix-collect-garbage -d --option use-xdg-base-directories true removing old generations of profile /nix/var/nix/profiles/per-user/root/profile removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile removing old generations of profile /nix/var/nix/profiles/system removing old generations of profile /nix/var/nix/profiles/default removing old generations of profile /nix/var/nix/profiles/per-user/root/profile removing old generations of profile /nix/var/nix/profiles/per-user/root/home-manager finding garbage collector roots... <snip> ❯ ls .local/state/nix/profiles home-manager@ home-manager-14-link@ home-manager-15-link@ home-manager-16-link@ profile@ profile-12-link@ profile-13-link@ profile-14-link@ ❯ nix-collect-garbage -d removing old generations of profile /home/k900/.local/state/nix/profiles/home-manager removing profile version 14 removing profile version 15 removing old generations of profile /home/k900/.local/state/nix/profiles/profile removing profile version 12 removing profile version 13 removing old generations of profile /nix/var/nix/profiles/per-user/k900/profile finding garbage collector roots... <snip> ``` **Expected behavior** home-manager generations are cleaned up on the first `sudo nix-collect-garbage -d` invocation. **`nix-env --version` output** `nix-collect-garbage (Nix) 2.16.1` **Additional context** I'm not sure when this started happening, but I feel like it might have something to do with HM switching to XDG paths? **Priorities** Add :+1: to [issues you find important](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc).
lix-bot added the
bug
imported
 labels 2024-03-19 01:01:30 +00:00
jade commented 2024-03-26 00:51:26 +00:00
Owner
Copy link

we don't think this should have shipped as it currently exists. that directory should have been a symlink to /nix/var/nix/profiles/per-user

disposition after discussion with @lunaphied: unship the feature, and replace it with a symlink to /nix/var/nix/profiles/per-user/USER

we don't think this should have shipped as it currently exists. that directory should have been a symlink to /nix/var/nix/profiles/per-user disposition after discussion with @lunaphied: unship the feature, and replace it with a symlink to `/nix/var/nix/profiles/per-user/USER`
qyriad added the
Area/profiles
 label 2024-04-27 04:47:43 +00:00
qyriad added this to the v2.90 milestone 2024-04-29 13:10:32 +00:00
jade modified the milestone from v2.90 to post-release 2024-08-13 01:19:27 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.91
sb/raito/phantom-referrers-gc
repl-overlay-example
reuse-compliance
release-2.90
git-series/activity-cleanup
sb/tom-hubrecht/primops.cc-v2
sb/bacchanalia/cache-strlen%topic=substr-perf
sb/arcuru/commit-msg
sb/qyriad/beta-1
sb/qyriad/2.90-beta.0
rbt/pre-commit-update
sb/rbt/test-branch
sb/rbt/justfile
sb/rbt/repl-overlays
sb/fuck/what
sb/rbt/pre-commit
sb/rbt/makeflags
sb/pennae/io-rewrite
sb/qyriad/maint-meson
sb/qyriad/maint/meson
sb/puck/meson-c-api
sb/pennae/parser-rewrite
sb/jade/burn-it-all
dependabot/github_actions/zeebe-io/backport-action-2.4.1
dependabot/github_actions/cachix/install-nix-action-25
dependabot/github_actions/actions/labeler-5
dependabot/github_actions/cachix/cachix-action-14
2.91.1
2.91.0
2.90.0
2.90.0-rc1
2.90-beta.1
2.90-beta.0
Labels
Clear labels   
Area/build-packaging

regarding the building or packaging of Lix itself

  
Area/cli

The command line interface of Lix

  
Area/evaluator

libexpr and anything else related to the evaluation of Nix expressions

  
Area/fetching

Fetching sources or other materials from the World Wide Web in Lix

  
Area/flakes

   
Area/language

language design, features, extensions, etc

  
Area/profiles

profiles: nix-env, nix profile, and installer flavors all alike

  
Area/protocol

The protocol, used for communicating between the client and the daemon

  
Area/releng

Release engineering

  
Area/remote-builds

remote builds

  
Area/repl

nix repl

  
Area/store

libstore and anything else relating to the Nix store

  
bug

it's a bug

  
crash 💥

Lix crashes (possibly bad error handling)

  
Cross Compilation

   
devx

development experience issues

  
docs

requires or is about documentation changes

  
Downstream Dependents

regarding an external tool's usage with Lix (e.g. nix-eval-jobs)

  
E/easy

bug is relatively simple and could simply be fixed with some minor effort

  
E/hard

this issue should probably be solved with close involvement of an expert

  
E/help wanted

maintainers may not get to this soon, but we want it fixed

  
E/reproducible

This bug is reproducible and obvious.

  
E/requires rearchitecture

this bug cannot be fixed properly without fixing a known architectural flaw

  
imported

Issue imported from upstream nix (please do not remove this label, it will cause dupes if import is rerun)

  
Needs Langver

We can't get to this until we implement language versioning

  
OS/Linux

Affects specifically Lix on Linux

  
OS/macOS

Affects specifically Lix on macOS

  
performance

make lix go faster

  
regression

This is a regression since some previous version of Lix

  
release-blocker

Blocks public release

  
RFD

Request for discussion

  
stability

Fixing this makes the software more stable

  
Status
blocked
Blocked on something

  
Status
invalid
not our bug, duplicate, similar

  
Status
postponed
closed but should maybe look at later (generally with S-wontfix)

  
Status
wontfix
We chose not to change this (see issue comments for more detail).

  
testing

Tests that should be added

  
testing/flakey

Tests that are unreliable/flakey (not to be confused with flakes that test)

  
ux

makes the user experience better :)

No labels
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/store
bug
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
imported
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
RFD
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
ux
Milestone
Clear milestone
No items
No milestone
post-release
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix#151
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?