nix-eval-jobs compat with nixpkgs-review 3.8.0 #1214

New issue

Open

opened 2026-05-13 23:30:55 +00:00 by mweinelt · 1 comment

mweinelt commented

2026-05-13 23:30:55 +00:00

Member

Describe the bug

Nixpkgs-review 3.8.0 started calling into nix-eval-jobs (since https://github.com/Mic92/nixpkgs-review/pull/595) with the --apply flag, which is not present in the Lix' fork.

https://github.com/Mic92/nixpkgs-review/pull/595

That means nixpkgs-review now fails with

$ nix-eval-jobs --workers 1 --max-memory-size 4096 --no-instantiate --extra-experimental-features 'nix-command no-url-literals' --nix-path 'nixpkgs=/home/hexa/.cache/nixpkgs-review/pr-519949-3/nixpkgs nixpkgs-overlays=/tmp/tmp7dyy5hb1' --no-allow-import-from-derivation --expr '(import /nix/store/m33aip6h3rm424izvnfqbf7bn7i1fdi1-nixpkgs-review-3.8.0/lib/python3.13/site-packages/nixpkgs_review/nix/evalAttrs.nix { attr-json = /tmp/tmp68maxr2o; })' --apply 'd: { inherit (d) exists broken; }'
warning: unknown experimental feature 'no-url-literals'
error: unrecognised flag '--apply'
Try 'nix-eval-jobs --help' for more information.
https://github.com/NixOS/nixpkgs/pull/519949 failed to build: nix-eval-jobs --workers 1 --max-memory-size 4096 --no-instantiate --extra-experimental-features nix-command no-url-literals --nix-path nixpkgs=/home/hexa/.cache/nixpkgs-review/pr-519949-3/nixpkgs nixpkgs-overlays=/tmp/tmp7dyy5hb1 --no-allow-import-from-derivation --expr (import /nix/store/m33aip6h3rm424izvnfqbf7bn7i1fdi1-nixpkgs-review-3.8.0/lib/python3.13/site-packages/nixpkgs_review/nix/evalAttrs.nix { attr-json = /tmp/tmp68maxr2o; }) --apply d: { inherit (d) exists broken; } failed to run, /tmp/tmp68maxr2o was stored inspection

The apply flag was added in github.com/NixOS/nix-eval-jobs@ca0652bdf4.

Steps To Reproduce

Update to nixpkgs-review 3.8.0
Run nixpkgs-review pr 519949
See error

Expected behavior

Ideally, nix-eval-jobs should stay API compatible with upstream.

`nix --version` output

nix (Lix, like Nix) 2.96.0-dev-pre20260507-dev_7831c98
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /root/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/root/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/root/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/root/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/gsyy520dxnpxky18xg2i4p49ayxhbvlq-lix-2.96.0-dev-pre20260507-dev_7831c98/share

Additional context

n/a

## Describe the bug Nixpkgs-review 3.8.0 started calling into nix-eval-jobs (since https://github.com/Mic92/nixpkgs-review/pull/595) with the `--apply` flag, which is not present in the Lix' fork. https://github.com/Mic92/nixpkgs-review/pull/595 That means nixpkgs-review now fails with ``` $ nix-eval-jobs --workers 1 --max-memory-size 4096 --no-instantiate --extra-experimental-features 'nix-command no-url-literals' --nix-path 'nixpkgs=/home/hexa/.cache/nixpkgs-review/pr-519949-3/nixpkgs nixpkgs-overlays=/tmp/tmp7dyy5hb1' --no-allow-import-from-derivation --expr '(import /nix/store/m33aip6h3rm424izvnfqbf7bn7i1fdi1-nixpkgs-review-3.8.0/lib/python3.13/site-packages/nixpkgs_review/nix/evalAttrs.nix { attr-json = /tmp/tmp68maxr2o; })' --apply 'd: { inherit (d) exists broken; }' warning: unknown experimental feature 'no-url-literals' error: unrecognised flag '--apply' Try 'nix-eval-jobs --help' for more information. https://github.com/NixOS/nixpkgs/pull/519949 failed to build: nix-eval-jobs --workers 1 --max-memory-size 4096 --no-instantiate --extra-experimental-features nix-command no-url-literals --nix-path nixpkgs=/home/hexa/.cache/nixpkgs-review/pr-519949-3/nixpkgs nixpkgs-overlays=/tmp/tmp7dyy5hb1 --no-allow-import-from-derivation --expr (import /nix/store/m33aip6h3rm424izvnfqbf7bn7i1fdi1-nixpkgs-review-3.8.0/lib/python3.13/site-packages/nixpkgs_review/nix/evalAttrs.nix { attr-json = /tmp/tmp68maxr2o; }) --apply d: { inherit (d) exists broken; } failed to run, /tmp/tmp68maxr2o was stored inspection ``` The apply flag was added in https://github.com/NixOS/nix-eval-jobs/commit/ca0652bdf4781ed64b6bacb33102f9e44ad07ba4. ## Steps To Reproduce 1. Update to nixpkgs-review 3.8.0 2. Run nixpkgs-review pr 519949 4. See error ## Expected behavior Ideally, nix-eval-jobs should stay API compatible with upstream. ## `nix --version` output ``` nix (Lix, like Nix) 2.96.0-dev-pre20260507-dev_7831c98 System type: x86_64-linux Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /root/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/root/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/root/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/root/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/gsyy520dxnpxky18xg2i4p49ayxhbvlq-lix-2.96.0-dev-pre20260507-dev_7831c98/share ``` ## Additional context n/a

👍 5 ❤️ 1

mweinelt added the

bug

label

2026-05-13 23:30:55 +00:00

ma27 self-assigned this

2026-05-15 09:30:24 +00:00

dwt commented

2026-06-02 06:41:23 +00:00

Accidentally reported this here and here before I figured out that nix-eval-jobs is a fork.

This is also blocking nixpkgs-review being switched to lix in https://github.com/NixOS/nixpkgs/pull/526938

Accidentally reported this [here](https://github.com/Mic92/nixpkgs-review/issues/647) and [here](https://github.com/NixOS/nix-eval-jobs/issues/415) before I figured out that nix-eval-jobs is a fork. This is also blocking nixpkgs-review being switched to lix in https://github.com/NixOS/nixpkgs/pull/526938