REPL overlays are not loaded when doing :st in nix-eval-spawned debugger #1212
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
diagnostics
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1212
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
When using
nix eval --debugger, REPL overlays are not loaded after an:stcommand (but are after e.g.:s). This specifically doesn't happen when trying to do the same usingnix repl --debugger.Steps To Reproduce
(This also happens if you change stack frame btw)
Expected behavior
The REPL overlays get reloaded and added to the lexical scope each time (or maybe don't get reloaded if we didn't change frame, but stay in scope).
nix --versionoutputThis also happens on Lix 2.95.3
Additional context
Since this doesn't happen when used directly from the repl, this might be related to #777? Just guessing, I haven't looked at the stackframe-changing code (nor the stepping one), so no idea if that could interfere at all.
repl overlays applying in a spawned debugger (rather than a repl started with
--debugger) is not well-defined anyway. the debugger executes inside an existing environment stack that cannot be modified without fucking up execution when continuing on from a breakpoint, they can't be loaded globally before starting execution (obviously), and they can't be loaded inside the environment that spawned the debugger and applied as inner layers each time (because not least of all that can easily shadow things, making debugger results dependant on overlay layout)maybe we should just ignore that setting entirely when spawning a debugger