Empty store path name for URLs with multiple trailing slashes in fetchurl #1185
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
diagnostics
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1185
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
fetchurlin Lix and Nix handle multiple trailing slashes in URLs differently.Nix handles this fine, but Lix fails.
Steps To Reproduce
Run
nix-instantiate --eval -E 'builtins.fetchurl "https://nixos.org//"'Lix returns
Expected behavior
The same command but with Nix
nix --versionoutputnix (Lix, like Nix) 2.94.1
System type: x86_64-linux
After a quick investigation, I found that fetchurl behaviour changed here:
github.com/NixOS/nix@9884018dfaThis change was initially discovered here: https://cl.snix.dev/c/snix/+/31164
Maybe the discussion in the CL will be helpful
This issue was mentioned on Gerrit on the following CLs:
We chatted with the core team, we agree something should be done about this. I'm not exactly sure we should cherry-pick the original change. If we do, we need to add the explanation and the proof this is the right fix, which is not contained in any of the commit message. A release note should be added as well.