"Deprecated features" error in repl when:add-ing on builtins and attempting to use true, false, and null #1176
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
diagnostics
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1176
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
Lix throws "deprecated features" error when using
:addonbuiltinsand attempting to usetrue,false, andnull.Steps To Reproduce
nix repl.:add builtins.true.Expected behavior
Lix doesn't complain and simply move on.
nix --versionoutputAdditional context
Currently none.
Note the workaround:
--extra-deprecated-features shadow-internal-symbols.This is definitely a bug though.
why should this be a bug? we are literally shadowing the builtin names from global scope. that we happen to be shadowing them with the identical value is immaterial unless you want to disable the shadowing warning for all cases in which this happens, but that would undermine the entire point of having the warning in the first place?
I mean, is it really shadowing if it's the literally the exact object? I guess.
But from a UX perspective
:add builtinsis a very reasonable and obvious thing to want to do. Maybe:addshould just skip internal symbol names instead of erroring on them?Thankfully we don't have this problem with
withsince it doesn't shadow.