Builds shouldn't fail if a subsitutor is returning 500 #1161
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
Importance
High
Importance
Low
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
Release Blocking
Non-urgent
Release Blocking
Urgent
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
Urgency
High
Urgency
Low
ux
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1161
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
I couldn't disable my substitor config even because I couldn't switch!
The problem was that my server ran an ancient nix daemon (2023) which is incompatible with recent lix.
I'd expect it to just continue after getting 500 errors from a substitor
Steps To Reproduce
you cna reproduce by making a faulty substitor with netcat:
Then you just set your normal nix config to use that substitor and it'll get 500 errors on any substitute attempt
Expected behavior
It should figure out the substitor is faulty and at least disable it for the current build.
Having a single substitor fail breaking my entire build system isn't acceptable.
nix --versionoutputAdditional context
I understand these situations are rare but they do happen!
running your reproducer on 2.95 we get this instead:
extending reproducer slightly to produce a cache with valid metadata by having
does not cause a failure, but a long list of retries (too long, we do consider that a bug):
so we'd consider your problem fixed, but we probably should not be retrying the same substituter quite this often if it's failing