docs.lix.systems edit links open cls even when nothing is changed #1019
Labels
No labels
Affects/CppNix
Affects/Nightly
Affects/Only nightly
Affects/Stable
Area/build-packaging
Area/cli
Area/evaluator
Area/fetching
Area/flakes
Area/language
Area/lix ci
Area/nix-eval-jobs
Area/profiles
Area/protocol
Area/releng
Area/remote-builds
Area/repl
Area/repl/debugger
Area/store
awaiting
author
awaiting
contributors
bug
Context
contributors
Context
drive-by
Context
maintainers
Context
RFD
crash 💥
Cross Compilation
devx
docs
Downstream Dependents
E/easy
E/hard
E/help wanted
E/reproducible
E/requires rearchitecture
Feature/S3
imported
Language/Bash
Language/C++
Language/NixLang
Language/Python
Language/Rust
Needs Langver
OS/Linux
OS/macOS
performance
regression
release-blocker
stability
Status
blocked
Status
invalid
Status
postponed
Status
wontfix
testing
testing/flakey
Topic/Large Scale Installations
ux
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
lix-project/lix#1019
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
clicking an edit link on docs.lix.systems while in the 2.93 (and also current stable) docs immediately creates a CL on gerrit if the user clicking the link is logged in. if an actual edit is made that's fine, but if it was a misclick we end up with an empty cl. that's not great
(thanks to @helle for finding this)
cl/4555andcl/4552are probably yet more instances of this. maybe we should remove the direct edit link altogether and put a short guide in its place?we noticed this while implementing it originally. i don't think it's avoidable unfortunately, Gerrit seems to only let you do these edits as a cl. i personally don't have issues with it, but we could implement a periodic cleanup task that abandons empty cls?
have we even had a gerrit-based edit to the docs since the feature was added? all CLs with the telltale subject line are misclicks :/
in favor of dropping it tbh, though i can just filter out the misclicks in my mind
I am considering patching the doc generator and having the links have a confirm popup in front of them, this would literally avoid the clicks I have been doing anyway.