lix-project/lix
20
55
Fork 31
Code Issues 344 Code Review (Gerrit) Projects 3 Releases Wiki Activity
14024 commits 29 branches 6 tags 85 MiB
Commit graph

14024 commits

This branch
This branch
All branches
Author SHA1 Message Date
Eelco Dolstra 1bb81286d1
Merge pull request #8006 from edolstra/fix-read-from-stdin 
Fix uninitialized readFromStdIn variable
 2023-03-08 14:29:27 +01:00
Eelco Dolstra bda8d7f165 Fix coverage job 
https://hydra.nixos.org/build/211747539
 2023-03-08 14:20:10 +01:00
Eelco Dolstra 1607ad5076 Fix uninitialized readFromStdIn variable 
This was causing random failures in tests/ca/substitute.ca: 'nix copy
--file ./content-addressed.nix' wouldn't get the default installable
'.' applied in InstallablesCommand::load(), so it would do nothing.
 2023-03-08 13:53:20 +01:00
Eelco Dolstra df48040786
Merge pull request #7994 from edolstra/fix-ca-crash 
Fix crash/hang with CA derivations
 2023-03-08 12:15:55 +01:00
Eelco Dolstra 6b243ef2d5
Merge pull request #7993 from tweag/fix-profile-gc 
Fix `nix-collect-garbage -d` with the new profile location
 2023-03-08 11:10:45 +01:00
Eelco Dolstra 7bfed34367 Fix crash/hang with CA derivations 
The curl download can outlive DrvOutputSubstitutionGoal (if some other
error occurs), so at shutdown setting the promise to an exception will
fail because 'this' is no longer valid in the callback. This can
manifest itself as a segfault, "corrupted double-linked list" or hang.
 2023-03-08 11:09:15 +01:00
Théophane Hufschmitt 4a6244dcf7
Merge pull request #7725 from yorickvP/check-coro-gc 
Disable GC during coroutine execution + test
 2023-03-08 09:51:46 +01:00
Théophane Hufschmitt 2272bc6049 Fix nix-collect-garbage -d with the new profile location 
Low-hanging fix for https://github.com/NixOS/nix/pull/5226#issuecomment-1454669399
 2023-03-07 13:08:04 +01:00
Théophane Hufschmitt ba0486f045
Merge pull request #7889 from sidkshatriya/sorted-fetch-paths 
Print the store paths to be fetched sorted by StorePath name()
 2023-03-07 11:58:10 +01:00
Edwin Mackenzie-Owen 934431d06c add flake-compat to flake.nix and use sha256 in default.nix 2023-03-06 21:11:24 +01:00
mupdt 762cf7f214 no-op refactor: extract outLink generation into a function 2023-03-06 10:20:21 -05:00
Eelco Dolstra 02bf521968
Merge pull request #7580 from fricklerhandwerk/nix-team-add-john 
add @Ericson2314 to the Nix team
 2023-03-06 15:02:07 +01:00
Eelco Dolstra fc76852b66
Merge pull request #7957 from NixOS/update-cachix-install-nix 
Switch to cachix/install-nix-action@v20
 2023-03-06 11:09:39 +01:00
Eelco Dolstra 3f4dc61f7f
Merge pull request #7958 from amesgen/issue-7955 
InstallableFlake: Apply nix config in `getCursors`
 2023-03-06 11:08:51 +01:00
Eelco Dolstra 92771ca1be
Merge pull request #7975 from fricklerhandwerk/fix-fetchgit 
remove indentation in `fetchGit` attribute listing
 2023-03-06 11:00:40 +01:00
Théophane Hufschmitt 2fbb2562c1
Merge pull request #7376 from fricklerhandwerk/installable 
clarify definition of "installable"
 2023-03-06 10:44:14 +01:00
Valentin Gagarin dfeb83cac1 output paths of store derivations are now addressed explicitly 2023-03-06 03:32:14 +01:00
Valentin Gagarin f69d453c3e remove indentation in fetchGit attribute listing 
also reword a confusing sentence and add links to Git terminology
 2023-03-05 04:44:11 +01:00
Valentin Gagarin 2af9fd20c6 clarify definition of "installable" 
the term was hard to discover, as its definition and explanation were in
a very long document lacking an overview section.
search did not help because it occurs so often.

- clarify wording in the definition
- add an overview of installable types
- add "installable" to glossary
- link to definition from occurrences of the term
- be more precise about where store derivation outputs are processed
- installable Nix expressions must evaluate to a derivation

Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
 2023-03-05 01:46:17 +01:00
Valentin Gagarin 1e87d5f1ea make descriptions of each installable type an own subsection 
this is easier to edit, provides anchors for free, and renders correctly
on the terminal without additional effort.
 2023-03-05 01:46:17 +01:00
amesgen 77bb950566
InstallableFlake: Apply nix config in getCursors 2023-03-04 12:52:20 +01:00
Théophane Hufschmitt c3b5499dff
Switch to cachix/install-nix-action@v20 
Fixes the installation issue with the latest Nix.

Also revert the pinning to nix-2.13 since it's not needed any more.
 2023-03-04 11:41:24 +01:00
Sidharth Kshatriya 427555861b Print the store paths to be fetched sorted by StorePath name() and not baseName 
Presently when nix says something like:

```
these 486 paths will be fetched (511.54 MiB download, 6458.64 MiB unpacked):
 ...path1
 ...path2
 ...path3
    ...
    ...
 ...path486
```

It sorts path1, path2, path3, ..., path486 in lexicographic order of the
store path.

After this commit, nix will show path1, path2, path3, ..., path486 sorted by
StorePath name() (basically everything after the hash) rather than the store path.

This makes it easier to review what exactly is being downloaded at a glance,
especially when many paths need to be fetched.
 2023-03-03 21:46:35 +05:30
Eelco Dolstra 0507462c06
Merge pull request #7918 from zimbatm/fix-empty-nix-store-env 
treat empty NIX_STORE_DIR env vars as unset
 2023-03-03 13:49:56 +01:00
Valentin Gagarin e065131c1b
cosmetic indentation 
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
 2023-03-03 12:56:23 +01:00
Yorick 2683734936
Add talkative msg for coro gc debug 2023-03-03 11:43:47 +01:00
Jonas Chevalier dc8820c71f
fixup: use same style as getEnv 2023-03-03 11:34:36 +01:00
Jonas Chevalier b96d9c1687
fixup: remove warning entirely 
fixes 72e1e23051 (r1124211067)
 2023-03-03 11:32:06 +01:00
Eelco Dolstra 19c1a4699b
Merge pull request #7946 from cole-h/restore-static-bin-dist 
flake: restore binary-dist artifact to Hydra static builds
 2023-03-03 10:23:17 +01:00
Eelco Dolstra f0908f592c
Merge pull request #7942 from edolstra/remove-format 
Remove FormatOrString and remaining uses of format()
 2023-03-03 10:22:11 +01:00
Eelco Dolstra 28c3e4eb1d
Merge pull request #7949 from fricklerhandwerk/pr-tempate 
remove stale pull request template
 2023-03-03 10:21:43 +01:00
Valentin Gagarin 37c61907d7
Merge pull request #7605 from tweag/comments 
add comments
 2023-03-03 06:38:29 +01:00
Valentin Gagarin 82b2cbf0f9 remove stale pull request template 
the old one seems not to be picked up by GitHub anyway
 2023-03-03 05:42:19 +01:00
Théophane Hufschmitt 8730d3002f
Merge pull request #7594 from nrdxp/paths-from-stdin 
feat: read installable paths from stdin
 2023-03-02 19:56:27 +01:00
Théophane Hufschmitt 1f394d2107
Merge branch 'master' into paths-from-stdin 2023-03-02 19:20:51 +01:00
Cole Helbling a8d0ff1a11 flake: restore binary-dist artifact to Hydra static builds 2023-03-02 10:02:55 -08:00
Yorick 5bb6e3bfaf
NixRepl::mainLoop: restore old curRepl on function exit 
This fixes completion callbacks after entering and leaving a nested
debugger.
 2023-03-02 17:24:58 +01:00
Eelco Dolstra 3a2b3af824
Merge pull request #7943 from edolstra/fix-make-check 
Fix 'make check' inside 'nix develop'
 2023-03-02 16:54:37 +01:00
Eelco Dolstra 687d86f8ab
Merge pull request #7940 from tweag/fix-http-errors-encoding 
Log the decompressed body in case of http errors
 2023-03-02 16:25:09 +01:00
Jonas Chevalier 72e1e23051
Update src/libutil/util.cc 
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
 2023-03-02 16:17:20 +01:00
Eelco Dolstra 9c79ce353d Fix 'make check' inside 'nix develop' 2023-03-02 16:11:49 +01:00
Eelco Dolstra 29abc8e764 Remove FormatOrString and remaining uses of format() 2023-03-02 15:57:54 +01:00
Eelco Dolstra b9370fd7a0
Merge pull request #7941 from edolstra/stdout 
Check writes to stdout
 2023-03-02 15:57:31 +01:00
Eelco Dolstra b69a73a230 Get rid of some unchecked calls to std::cout 2023-03-02 15:02:24 +01:00
Théophane Hufschmitt 1a825b6919 Log the decompressed body in case of http errors 
Don't show the users the raw (possibly compressed) error message as
everyone isn't able to decompress brotli in their brain.
 2023-03-02 14:59:15 +01:00
Eelco Dolstra 09f5975c6a Logger::cout: Use fmt() 
This ensures that in cout(s), 's' does not get interpreted as a format
string.
 2023-03-02 14:52:37 +01:00
Eelco Dolstra 989b823ac5 nix store cat: Use writeFull() 
Fixes #7939.
 2023-03-02 14:51:14 +01:00
Eelco Dolstra c13cbd20ab Logger::writeToStdout(): Use writeFull() 
This ensures that write errors do not get ignored.
 2023-03-02 14:46:28 +01:00
Eelco Dolstra 85dbf9de8e
Merge pull request #7919 from NixOS/bump-2.15.0 
Bump version
 2023-03-02 10:41:36 +01:00
Eelco Dolstra 378508a877 Bump version 2023-03-02 10:01:24 +01:00