Robert Hensing
c965f35de7
Improve sqlite error messages
...
They did not include the detailed error message, losing essential
information for troubleshooting.
Example message:
warning: creating statement 'insert or rplace into NARs(cache, hashPart, namePart, url, compression, fileHash, fileSize, narHash, narSize, refs, deriver, sigs, ca, timestamp, present) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 1)': at offset 10: SQL logic error, near "rplace": syntax error (in '/tmp/nix-shell.grQ6f7/nix-test/tests/binary-cache/test-home/.cache/nix/binary-cache-v6.sqlite')
It's not the best example; more important information will be in
the message for e.g. a constraint violation.
I don't see why this specific error is printed as a warning, but
that's for another commit.
2022-12-17 14:51:37 +01:00
Solène Rapenne
d0660c6c0b
printMsg replacement by printInfo
...
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2022-12-16 09:34:22 +01:00
Taeer Bar-Yam
e5eb05c599
getBuildLog: factor out resolving derivations
2022-12-15 15:58:54 -05:00
Eelco Dolstra
26c7602c39
Merge pull request #7465 from edolstra/impure-derivations-dry-run
...
Fix a crash in DerivedPath::Built::toJSON() with impure derivations
2022-12-15 18:15:23 +01:00
Eelco Dolstra
0687e16c4a
Fix a crash in DerivedPath::Built::toJSON() with impure derivations
...
The use of 'nullptr' here didn't result in a null JSON value, but in a
nullptr being cast to a string, which aborts.
2022-12-15 16:02:27 +01:00
Solène Rapenne
98e01da0b1
warnings: switch to info level when using a saved substituter
2022-12-14 14:11:21 +01:00
Eelco Dolstra
5d77c08858
Merge pull request #7458 from ncfavier/disable-build-users
...
Allow disabling build users by unsetting `build-users-group`
2022-12-14 11:56:42 +01:00
TIAN Yuanhao
09830ab829
Avoid poly_user_note_set twice
...
f06f810
incorrectly introduces a boolean flip, resulting in a senseless
poly_user_note_set even though the user comment has been set correctly.
2022-12-14 03:03:12 +00:00
Naïm Favier
1f3c0a3c1d
Allow disabling build users by unsetting build-users-group
...
Unsetting `build-users-group` (without `auto-allocate-uids` enabled)
gives the following error:
```
src/libstore/lock.cc:25: static std::unique_ptr<nix::UserLock> nix::SimpleUserLock::acquire(): Assertion `settings.buildUsersGroup != ""' failed.
```
Fix the logic in `useBuildUsers` and document the default value
for `build-users-group`.
2022-12-14 00:40:30 +01:00
Eelco Dolstra
9fa8b02c41
Merge pull request #7456 from ncfavier/fix-links
...
doc: fix links
2022-12-13 17:27:13 +01:00
Eelco Dolstra
46b3c026fc
Merge pull request #7455 from rapenne-s/documentation_fix
...
Add anchors and links to definition
2022-12-13 17:26:52 +01:00
Eelco Dolstra
e2a4e7aecd
Merge pull request #4543 from obsidiansystems/indexed-store-path-outputs
...
Low level `<drvPath>^<outputName>` installable syntax to match existing `<highLevelInstallable>^<outputNames>` syntax
2022-12-13 17:22:29 +01:00
Eelco Dolstra
c9b0a85b08
Restore display of source lines for stdin/string inputs
2022-12-13 16:00:44 +01:00
Naïm Favier
129ece7ce9
doc: fix links
2022-12-13 15:49:40 +01:00
Eelco Dolstra
aea97f07a3
Fix compilation
2022-12-13 15:23:12 +01:00
Eelco Dolstra
1315133b50
Improve cast safety
...
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
2022-12-13 12:38:33 +01:00
Solène Rapenne
09860c16ce
documentation: use sections instead of list items
2022-12-13 11:47:44 +01:00
Solène Rapenne
e43b0f5b12
documentation: link flake URL term to definition
2022-12-13 11:47:38 +01:00
Solène Rapenne
ae27181f16
documentation: fix link to definition
2022-12-13 11:47:22 +01:00
Eelco Dolstra
af5582ca53
Merge pull request #7454 from tweag/build-no-gc-in-hydra
...
Build Nix with the GC disabled in hydra
2022-12-13 11:23:33 +01:00
Théophane Hufschmitt
2ec6685eb0
Build Nix with the GC disabled in hydra
...
Make sure that it still compiles as it's easy to accidentally break one
of the `#if` guarded clauses
2022-12-13 10:44:07 +01:00
Théophane Hufschmitt
6e31d27cba
Merge pull request #6741 from Mindavi/nix-no-gc
...
support building with --enable-gc=no
2022-12-13 10:36:59 +01:00
Eelco Dolstra
b3fdab28a2
Introduce AbstractPos
...
This makes the position object used in exceptions abstract, with a
method getSource() to get the source code of the file in which the
error originated. This is needed for lazy trees because source files
don't necessarily exist in the filesystem, and we don't want to make
libutil depend on the InputAccessor type in libfetcher.
2022-12-13 00:50:43 +01:00
John Ericson
f61d575810
Merge branch 'indexed-store-path-outputs' of github.com:obsidiansystems/nix into indexed-store-path-outputs
2022-12-12 17:43:10 -05:00
John Ericson
5273cf4c97
Merge remote-tracking branch 'upstream/master' into indexed-store-path-outputs
2022-12-12 17:40:49 -05:00
John Ericson
32ae715db1
Fix typos in the docs
...
Thanks!
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2022-12-12 17:37:45 -05:00
John Ericson
dabb03b8d0
Merge remote-tracking branch 'upstream/master' into indexed-store-path-outputs
2022-12-12 17:36:02 -05:00
John Ericson
c886b18561
Merge new tests into build.sh
2022-12-12 17:34:57 -05:00
John Ericson
d8c1c24c78
Adjust docs
2022-12-12 17:32:24 -05:00
Rick van Schijndel
672ee88231
support building with --enable-gc=no
...
Some minor changes fixing the build without boehm.
Fixes NixOS#6250
2022-12-12 23:31:30 +01:00
John Ericson
c7cce3e4e1
Improve release notes
2022-12-12 16:29:49 -05:00
John Ericson
dc075dcdd0
Apply suggestions from code review
...
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2022-12-12 16:26:10 -05:00
Valentin Gagarin
edb54c62e6
Merge pull request #7334 from chaoflow/stack-trace-order
...
Show stack trace above error message with innermost first
2022-12-12 22:03:00 +01:00
Eelco Dolstra
900b854084
Add CanonPath wrapper to represent canonicalized paths
2022-12-12 19:57:32 +01:00
Florian Friesdorf
8618c6cc75
Simplify loop, feedback from @tfc and @Ericson2314
2022-12-12 18:41:00 +00:00
John Ericson
7b122d43a4
Fix stack context notes to not rely on order
...
Make everything be in the form "while ..." (most things were already),
and in particular *don't* use other propositions that must go after or
before specific "while ..." clauses to make sense.
2022-12-12 18:41:00 +00:00
Florian Friesdorf
d269976be6
Show stack trace above error message
...
Save developers from scrolling by displaying the error message last,
below the stack trace.
2022-12-12 18:41:00 +00:00
Florian Friesdorf
173dcb0af9
Don't reverse stack trace when showing
...
When debugging nix expressions the outermost trace tends to be more useful
than the innermost. It is therefore printed last to save developers from
scrolling.
2022-12-12 18:41:00 +00:00
Eelco Dolstra
e408af82ab
Merge pull request #7436 from edolstra/enable-lang-tests
...
Enable some language tests that were accidentally disabled
2022-12-12 17:39:02 +01:00
Théophane Hufschmitt
a642b10301
Merge pull request #5420 from bew/allow-disable-global-registry
...
Allow to disable global flake-registry with ""
2022-12-12 17:08:01 +01:00
Eelco Dolstra
e86530ee46
Fix reference to test directory path
2022-12-12 16:55:42 +01:00
Eelco Dolstra
17f81d3215
Fix unused variable warning
2022-12-12 16:41:46 +01:00
Eelco Dolstra
8e8a511aa0
Enable some language tests that were accidentally disabled
...
This didn't run because the corresponding .exp file didn't exist.
2022-12-12 16:39:06 +01:00
Benoit de Chezelles
a456630a5a
Allow to disable global flake-registry with ""
2022-12-12 15:32:02 +01:00
Eelco Dolstra
11ef807c22
Merge pull request #7448 from edolstra/remove-auto-assign
...
Remove auto assign
2022-12-12 15:01:56 +01:00
Eelco Dolstra
5a11c9b6f5
Merge pull request #7423 from edolstra/legacy-cli-flakes
...
Support flake references in the old CLI
2022-12-12 14:34:27 +01:00
Valentin Gagarin
4ed8bb1cb1
suggestions from review
2022-12-12 14:29:24 +01:00
Eelco Dolstra
7a85199f87
Add docs from the lazy-trees branch
2022-12-12 14:06:13 +01:00
Eelco Dolstra
fa409131cd
Add links to the manual
...
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2022-12-12 14:05:54 +01:00
Eelco Dolstra
fd0ed75118
Support flake references in the old CLI
...
Fixes #7026 .
2022-12-12 14:05:52 +01:00