From e69cfdebb090b3aabbff69a44504883d5b6fb866 Mon Sep 17 00:00:00 2001
From: regnat <rg@regnat.ovh>
Date: Thu, 4 Feb 2021 15:15:22 +0100
Subject: [PATCH] Remove the `visit` machinery in `RealisedPath`

In addition to being some ugly template trickery, it was also totally
useless as it was used in only one place where I could replace it by
just a few extra characters
---
 src/libstore/realisation.cc |  2 +-
 src/libstore/realisation.hh | 13 -------------
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/src/libstore/realisation.cc b/src/libstore/realisation.cc
index e4276c040..cd74af4ee 100644
--- a/src/libstore/realisation.cc
+++ b/src/libstore/realisation.cc
@@ -47,7 +47,7 @@ Realisation Realisation::fromJSON(
 }
 
 StorePath RealisedPath::path() const {
-    return visit([](auto && arg) { return arg.getPath(); });
+    return std::visit([](auto && arg) { return arg.getPath(); }, raw);
 }
 
 void RealisedPath::closure(
diff --git a/src/libstore/realisation.hh b/src/libstore/realisation.hh
index 557f54362..7c91d802a 100644
--- a/src/libstore/realisation.hh
+++ b/src/libstore/realisation.hh
@@ -58,19 +58,6 @@ struct RealisedPath {
     RealisedPath(StorePath path) : raw(OpaquePath{path}) {}
     RealisedPath(Realisation r) : raw(r) {}
 
-    /**
-     * Syntactic sugar to run `std::visit` on the raw value:
-     * path.visit(blah) == std::visit(blah, path.raw)
-     */
-    template <class Visitor>
-    constexpr decltype(auto) visit(Visitor && vis) {
-        return std::visit(vis, raw);
-    }
-    template <class Visitor>
-    constexpr decltype(auto) visit(Visitor && vis) const {
-        return std::visit(vis, raw);
-    }
-
     /**
      * Get the raw store path associated to this
      */